qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Nikos Filippakis <aesmade@gmail.com>
To: qemu-devel@nongnu.org
Cc: Nikos Filippakis <aesmade@gmail.com>, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 2/4] omap1: Change qemu_system_reset_request to watchdog_perform_action where appropriate
Date: Mon, 14 Mar 2016 17:56:00 +0200	[thread overview]
Message-ID: <1457970960-25883-1-git-send-email-aesmade@gmail.com> (raw)

Instead of using qemu_system_reset_request() to reset when a watchdog triggers,
let watchdog_perform_action() decide what to do, as stated in the BiteSizedTasks
wiki page.

Signed-off-by: Nikos Filippakis <aesmade@gmail.com>
---
 hw/arm/omap1.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c
index 6f68130..4c719f8 100644
--- a/hw/arm/omap1.c
+++ b/hw/arm/omap1.c
@@ -28,6 +28,7 @@
 #include "sysemu/blockdev.h"
 #include "qemu/range.h"
 #include "hw/sysbus.h"
+#include "sysemu/watchdog.h"
 
 /* Should signal the TCMI/GPMC */
 uint32_t omap_badwidth_read8(void *opaque, hwaddr addr)
@@ -349,7 +350,7 @@ static void omap_wd_timer_write(void *opaque, hwaddr addr,
                 /* XXX: on T|E hardware somehow this has no effect,
                  * on Zire 71 it works as specified.  */
                 s->reset = 1;
-                qemu_system_reset_request();
+                watchdog_perform_action();
             }
         }
         s->last_wr = value & 0xff;
-- 
1.9.1

                 reply	other threads:[~2016-03-14 15:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457970960-25883-1-git-send-email-aesmade@gmail.com \
    --to=aesmade@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).