From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afZ4s-00076B-Of for qemu-devel@nongnu.org; Mon, 14 Mar 2016 16:26:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afZ4r-0004ly-PW for qemu-devel@nongnu.org; Mon, 14 Mar 2016 16:26:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afZ4r-0004lu-K8 for qemu-devel@nongnu.org; Mon, 14 Mar 2016 16:26:57 -0400 From: Eduardo Habkost Date: Mon, 14 Mar 2016 17:26:48 -0300 Message-Id: <1457987208-18968-3-git-send-email-ehabkost@redhat.com> In-Reply-To: <1457987208-18968-1-git-send-email-ehabkost@redhat.com> References: <1457987208-18968-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 2/2] kvm: Remove x2apic feature from CPU model when kernel_irqchip is off List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Paolo Bonzini , Lan Tianyu , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Richard Henderson From: Lan Tianyu x2apic feature is in the kvm_default_props and automatically added to all CPU models when KVM is enabled. But userspace devices don't support x2apic which can't be enabled without the in-kernel irqchip. It will trigger warning of "host doesn't support requested feature: CPUID.01H:ECX.x2apic [bit 21]" when kernel_irqchip is off. This patch is to fix it via removing x2apic feature when kernel_irqchip is off. Signed-off-by: Lan Tianyu Acked-by: Paolo Bonzini Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 0f38d1e..3ea6b29 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -2132,6 +2132,10 @@ static void x86_cpu_load_def(X86CPU *cpu, X86CPUDefinition *def, Error **errp) /* Special cases not set in the X86CPUDefinition structs: */ if (kvm_enabled()) { + if (!kvm_irqchip_in_kernel()) { + x86_cpu_change_kvm_default("x2apic", "off"); + } + x86_cpu_apply_props(cpu, kvm_default_props); } -- 2.1.0