From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afjUd-00088P-Vq for qemu-devel@nongnu.org; Tue, 15 Mar 2016 03:34:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afjUa-00007Y-6M for qemu-devel@nongnu.org; Tue, 15 Mar 2016 03:34:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afjUa-00007R-0v for qemu-devel@nongnu.org; Tue, 15 Mar 2016 03:34:12 -0400 Message-ID: <1458027249.13231.27.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 15 Mar 2016 08:34:09 +0100 In-Reply-To: <20160315091411-mutt-send-email-mst@redhat.com> References: <1457974531-8768-1-git-send-email-minyard@acm.org> <20160315085654-mutt-send-email-mst@redhat.com> <1458025488.13231.20.camel@redhat.com> <20160315091411-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , qemu-devel@nongnu.org, minyard@acm.org, Corey Minyard On Di, 2016-03-15 at 09:17 +0200, Michael S. Tsirkin wrote: > On Tue, Mar 15, 2016 at 08:04:48AM +0100, Gerd Hoffmann wrote: > > Hi, > >=20 > > > > Don't add a new machine type in this version, just use the 2.6 one. > > >=20 > > > Unfortunately this patch won't help any, as your next patch reorders = fw > > > cfg files which will affect the old machine types. > >=20 > > We can make that depend on dont_sort_fw_cfgs too, to keep things as-is > > on old machine types. >=20 > Yes, except the name is a bit off then. It's more "legacy_fw_cfg_order" > than "dont_sort_fw_cfgs". >=20 > > Which probably implies only new machine types > > will see the new smbios entries. > >=20 > > cheers, > > Gerd >=20 > Not really I think. > If there's a new device triggering a new smbios entry, we don't care how > it's sorted since by then there's no question of cross-version migration > with old QEMU. As I understand things the smbios fw_cfg file must be created later to make new entries (created by devices) are actually visible. So we can make that initialization order change depend on dont_sort_fw_cfgs (or legacy_fw_cfg_order) too. That way we maintain the ordering for old machine types. But old machine types then will also not see the entries added by devices. Which isn't a problem I think, old qemu versions don't have support for that device in the first place ... Corey, can you please send all this in a patch series? This should make those dependencies more clear ... thanks, Gerd >=20