From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, minyard@acm.org,
Corey Minyard <cminyard@mvista.com>
Subject: Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list
Date: Tue, 15 Mar 2016 09:45:22 +0100 [thread overview]
Message-ID: <1458031522.13231.39.camel@redhat.com> (raw)
In-Reply-To: <20160315093529-mutt-send-email-mst@redhat.com>
> Depends on how you code it up. We have a list, we look each file
> there and sort accordingly. Fine.
> New devices will not be on this list, I guess you can just ignore them
> and guests will not see them. OK but I think it is better to make old
> machine types see them.
Not a new fw_cfg file.
It's existing smbios file which gets new records added by a new device.
So when initializing it early (old order) it doesn't (yet) contain the
new records. When initializing it late it has them, but also has a
different place in the fw_cfg directory.
So old machine types initialize smbios early (for compatibility).
New machine types initialize smbios late (so guests see the new
records).
While mucking with the file ordering anyway: Good opportunity to make
new machine types also sort the fw_cfg directory entries, so they get a
fixed order independent from the order they are created, and we will not
face this problem again.
cheers,
Gerd
next prev parent reply other threads:[~2016-03-15 8:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 16:55 [Qemu-devel] [PATCH v2] Sort the fw_cfg file list minyard
2016-03-15 6:57 ` Michael S. Tsirkin
2016-03-15 7:04 ` Gerd Hoffmann
2016-03-15 7:17 ` Michael S. Tsirkin
2016-03-15 7:34 ` Gerd Hoffmann
2016-03-15 7:45 ` Michael S. Tsirkin
2016-03-15 8:45 ` Gerd Hoffmann [this message]
2016-03-15 9:37 ` Michael S. Tsirkin
2016-03-15 12:38 ` Corey Minyard
2016-03-15 12:45 ` Michael S. Tsirkin
2016-03-15 12:56 ` Corey Minyard
2016-03-15 13:47 ` Michael S. Tsirkin
2016-03-15 14:43 ` Michael S. Tsirkin
2016-03-15 16:36 ` Corey Minyard
2016-03-15 17:01 ` Michael S. Tsirkin
2016-03-16 15:21 ` Corey Minyard
2016-03-16 15:34 ` Paolo Bonzini
2016-03-16 15:37 ` Michael S. Tsirkin
2016-03-15 13:03 ` Gerd Hoffmann
2016-03-15 13:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458031522.13231.39.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=cminyard@mvista.com \
--cc=minyard@acm.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).