From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58864)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1afkbb-00008T-3Q
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 04:45:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1afkbW-0002h4-41
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 04:45:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49524)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1afkbV-0002gz-Ub
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 04:45:26 -0400
Message-ID: <1458031522.13231.39.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 15 Mar 2016 09:45:22 +0100
In-Reply-To: <20160315093529-mutt-send-email-mst@redhat.com>
References: <1457974531-8768-1-git-send-email-minyard@acm.org>
	<20160315085654-mutt-send-email-mst@redhat.com>
	<1458025488.13231.20.camel@redhat.com>
	<20160315091411-mutt-send-email-mst@redhat.com>
	<1458027249.13231.27.camel@redhat.com>
	<20160315093529-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, minyard@acm.org, Corey Minyard <cminyard@mvista.com>

> Depends on how you code it up.  We have a list, we look each file
> there and sort accordingly.  Fine.
> New devices will not be on this list, I guess you can just ignore them
> and guests will not see them. OK but I think it is better to make old
> machine types see them.

Not a new fw_cfg file.

It's existing smbios file which gets new records added by a new device.
So when initializing it early (old order) it doesn't (yet) contain the
new records.  When initializing it late it has them, but also has a
different place in the fw_cfg directory.

So old machine types initialize smbios early (for compatibility).

New machine types initialize smbios late (so guests see the new
records).

While mucking with the file ordering anyway:  Good opportunity to make
new machine types also sort the fw_cfg directory entries, so they get a
fixed order independent from the order they are created, and we will not
face this problem again.

cheers,
  Gerd