qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
	Wei Jiangang <weijg.fnst@cn.fujitsu.com>
Subject: [Qemu-devel] [PATCH] accel: make configure_accelerator return void
Date: Tue, 15 Mar 2016 18:07:43 +0800	[thread overview]
Message-ID: <1458036463-20180-1-git-send-email-weijg.fnst@cn.fujitsu.com> (raw)

Return the negated value of accel_initialised is meaningless,
and the caller vl doesn't check it.

Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
---
 accel.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/accel.c b/accel.c
index 0510b90..403eb5e 100644
--- a/accel.c
+++ b/accel.c
@@ -77,7 +77,7 @@ static int accel_init_machine(AccelClass *acc, MachineState *ms)
     return ret;
 }
 
-int configure_accelerator(MachineState *ms)
+void configure_accelerator(MachineState *ms)
 {
     const char *p;
     char buf[10];
@@ -128,8 +128,6 @@ int configure_accelerator(MachineState *ms)
     if (init_failed) {
         fprintf(stderr, "Back to %s accelerator.\n", acc->name);
     }
-
-    return !accel_initialised;
 }
 
 
-- 
1.9.3

             reply	other threads:[~2016-03-15 10:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15 10:07 Wei Jiangang [this message]
2016-04-14  3:19 ` [Qemu-devel] [PATCH] accel: make configure_accelerator return void Wei, Jiangang
2016-04-14  3:34   ` Changlong Xie
2016-04-14  3:53     ` Wei, Jiangang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458036463-20180-1-git-send-email-weijg.fnst@cn.fujitsu.com \
    --to=weijg.fnst@cn.fujitsu.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).