From: Gerd Hoffmann <kraxel@redhat.com>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port
Date: Tue, 15 Mar 2016 15:32:31 +0100 [thread overview]
Message-ID: <1458052351.13231.85.camel@redhat.com> (raw)
In-Reply-To: <20160315141723.GL1546@edamame.cdg.redhat.com>
On Di, 2016-03-15 at 15:17 +0100, Christophe Fergeau wrote:
> On Tue, Mar 15, 2016 at 02:09:47PM +0100, Gerd Hoffmann wrote:
> > Hi,
> >
> > > Yes, long-term we will want to remove this once spice gets support for
> > > this.
> >
> > How can qemu figure whenever spice supports gl+tcp or not?
>
> gl support is already enabled through a spice-server version check
>
> #if defined(CONFIG_OPENGL_DMABUF)
> # if SPICE_SERVER_VERSION >= 0x000d01 /* release 0.13.1 */
> # define HAVE_SPICE_GL 1
> # include "ui/egl-helpers.h"
> # include "ui/egl-context.h"
> # endif
> #endif
Sure, qemu needed to figure whenever spice-server provides the gl API.
> We can do something similar once gl+tcp is available.
I don't expect adding gl+tcp support to spice needs changes in the
spice-server API and qemu. So ifdef'ing on the spice-server version is
bogous, especially as the version you compiled qemu against can be newer
or older as the version used to run qemu.
cheers,
Gerd
next prev parent reply other threads:[~2016-03-15 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 11:41 [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port Christophe Fergeau
2016-03-14 13:34 ` Marc-André Lureau
2016-03-14 15:00 ` Gerd Hoffmann
2016-03-14 15:16 ` Christophe Fergeau
2016-03-15 13:09 ` Gerd Hoffmann
2016-03-15 14:17 ` Christophe Fergeau
2016-03-15 14:32 ` Gerd Hoffmann [this message]
2016-03-16 9:10 ` Christophe Fergeau
2016-03-14 15:41 ` Eric Blake
2016-03-15 9:49 ` Christophe Fergeau
2016-03-18 8:17 ` Gerd Hoffmann
2016-03-18 9:07 ` Christophe Fergeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458052351.13231.85.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=cfergeau@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).