From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48747)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1afq1Z-0004UP-2d
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:32:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1afq1V-0005m2-9P
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:32:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44474)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1afq1V-0005ls-53
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:32:37 -0400
Message-ID: <1458052351.13231.85.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 15 Mar 2016 15:32:31 +0100
In-Reply-To: <20160315141723.GL1546@edamame.cdg.redhat.com>
References: <1457955672-28758-1-git-send-email-cfergeau@redhat.com>
	<1457967611.5358.18.camel@redhat.com>
	<20160314151645.GI27985@edamame.cdg.redhat.com>
	<1458047387.13231.48.camel@redhat.com>
	<20160315141723.GL1546@edamame.cdg.redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org

On Di, 2016-03-15 at 15:17 +0100, Christophe Fergeau wrote:
> On Tue, Mar 15, 2016 at 02:09:47PM +0100, Gerd Hoffmann wrote:
> >   Hi,
> >=20
> > > Yes, long-term we will want to remove this once spice gets support fo=
r
> > > this.
> >=20
> > How can qemu figure whenever spice supports gl+tcp or not?
>=20
> gl support is already enabled through a spice-server version check
>=20
> #if defined(CONFIG_OPENGL_DMABUF)
> # if SPICE_SERVER_VERSION >=3D 0x000d01 /* release 0.13.1 */
> #  define HAVE_SPICE_GL 1
> #  include "ui/egl-helpers.h"
> #  include "ui/egl-context.h"
> # endif
> #endif

Sure, qemu needed to figure whenever spice-server provides the gl API.

> We can do something similar once gl+tcp is available.

I don't expect adding gl+tcp support to spice needs changes in the
spice-server API and qemu.  So ifdef'ing on the spice-server version is
bogous, especially as the version you compiled qemu against can be newer
or older as the version used to run qemu.

cheers,
  Gerd