From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afqFE-0004Zl-KS for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:46:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afqF9-0001aF-4F for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:46:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afqF8-0001Zy-VA for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:46:43 -0400 Message-ID: <1458053195.13231.92.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 15 Mar 2016 15:46:35 +0100 In-Reply-To: <20160315161755-mutt-send-email-mst@redhat.com> References: <1458050002-27741-1-git-send-email-mst@redhat.com> <56E818BD.2080906@redhat.com> <20160315161755-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , qemu-devel@nongnu.org, Corey Minyard Hi, > > I think we have already gone through this discussion. >=20 > So now Corey basically is prevented from sorting sanely > because command line might not start with opt/ Hmm? There are no guarantees whatsoever if the user used the command line for entries outside /opt. Beside that the "sort everything lexical for 2.6+" approach will work fine. I think it is more robust and I suspect we will have less hassle with it long-term. cheers, Gerd