From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afto9-0006ef-8l for qemu-devel@nongnu.org; Tue, 15 Mar 2016 14:35:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afto8-0001qb-5V for qemu-devel@nongnu.org; Tue, 15 Mar 2016 14:35:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afto7-0001q2-Vh for qemu-devel@nongnu.org; Tue, 15 Mar 2016 14:35:04 -0400 From: Markus Armbruster Date: Tue, 15 Mar 2016 19:34:36 +0100 Message-Id: <1458066895-20632-22-git-send-email-armbru@redhat.com> In-Reply-To: <1458066895-20632-1-git-send-email-armbru@redhat.com> References: <1458066895-20632-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v3 21/40] ivshmem: Assert interrupts are set up once List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: claudio.fontana@huawei.com, cam@cs.ualberta.ca, mlureau@redhat.com, david.marchand@6wind.com, pbonzini@redhat.com An interrupt is set up when the interrupt's file descriptor is received. Each message applies to the next interrupt vector. Therefore, each vector cannot be set up more than once. ivshmem_add_kvm_msi_virq() half-heartedly tries not to rely on this by doing nothing then, but that's not going to recover from this error should it become possible in the future. watch_vector_notifier() doesn't even try. Simply assert what is the case, so we get alerted if we ever screw it up. Signed-off-by: Markus Armbruster Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/misc/ivshmem.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 65e3a76..61e21cd 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -349,7 +349,7 @@ static void watch_vector_notifier(IVShmemState *s, Ev= entNotifier *n, { int eventfd =3D event_notifier_get_fd(n); =20 - /* if MSI is supported we need multiple interrupts */ + assert(!s->msi_vectors[vector].pdev); s->msi_vectors[vector].pdev =3D PCI_DEVICE(s); =20 qemu_set_fd_handler(eventfd, ivshmem_vector_notify, @@ -535,10 +535,7 @@ static int ivshmem_add_kvm_msi_virq(IVShmemState *s,= int vector) int ret; =20 IVSHMEM_DPRINTF("ivshmem_add_kvm_msi_virq vector:%d\n", vector); - - if (s->msi_vectors[vector].pdev !=3D NULL) { - return 0; - } + assert(!s->msi_vectors[vector].pdev); =20 ret =3D kvm_irqchip_add_msi_route(kvm_state, msg, pdev); if (ret < 0) { --=20 2.4.3