From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afvDw-0008VZ-2U for qemu-devel@nongnu.org; Tue, 15 Mar 2016 16:05:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afvDt-0008No-Io for qemu-devel@nongnu.org; Tue, 15 Mar 2016 16:05:47 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:27115 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afvDt-0008Ll-3H for qemu-devel@nongnu.org; Tue, 15 Mar 2016 16:05:45 -0400 From: Vladimir Sementsov-Ogievskiy Date: Tue, 15 Mar 2016 23:04:24 +0300 Message-Id: <1458072268-53705-19-git-send-email-vsementsov@virtuozzo.com> In-Reply-To: <1458072268-53705-1-git-send-email-vsementsov@virtuozzo.com> References: <1458072268-53705-1-git-send-email-vsementsov@virtuozzo.com> Subject: [Qemu-devel] [PATCH 18/22] qcow2-dirty-bitmaps: disallow stroing bitmap to other bs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, famz@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org, jsnow@redhat.com Check, that bitmap is stored to the owning bs. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 12 ++++++++++++ block/qcow2-dirty-bitmap.c | 5 +++++ include/block/dirty-bitmap.h | 2 ++ 3 files changed, 19 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 87ee4d7..9625f4a 100644 --- a/block/dirty-bitmap.c +++ b/block/dirty-bitmap.c @@ -485,3 +485,15 @@ BdrvDirtyBitmap *bdrv_load_dirty_bitmap(BlockDriverState *bs, const char *name, } return NULL; } + +bool bdrv_has_dirty_bitmap(BlockDriverState *bs, const BdrvDirtyBitmap *bitmap) +{ + BdrvDirtyBitmap *bm, *next; + QLIST_FOREACH_SAFE(bm, &bs->dirty_bitmaps, list, next) { + if (bm == bitmap) { + return true; + } + } + + return false; +} diff --git a/block/qcow2-dirty-bitmap.c b/block/qcow2-dirty-bitmap.c index f210fee..70c6e36 100644 --- a/block/qcow2-dirty-bitmap.c +++ b/block/qcow2-dirty-bitmap.c @@ -757,6 +757,11 @@ void qcow2_bitmap_store(BlockDriverState *bs, uint64_t size = bdrv_dirty_bitmap_size(bitmap); int granularity = bdrv_dirty_bitmap_granularity(bitmap); + if (!bdrv_has_dirty_bitmap(bs, bitmap)) { + error_setg(errp, "Can't store bitmap to the other node."); + return; + } + /* find/create dirty bitmap */ bm = find_bitmap_by_name(bs, name); if (bm == NULL) { diff --git a/include/block/dirty-bitmap.h b/include/block/dirty-bitmap.h index 66ba3f8..af76ac1 100644 --- a/include/block/dirty-bitmap.h +++ b/include/block/dirty-bitmap.h @@ -62,4 +62,6 @@ void bdrv_finalize_persistent_dirty_bitmaps(BlockDriverState *bs); BdrvDirtyBitmap *bdrv_load_dirty_bitmap(BlockDriverState *bs, const char *name, Error **errp); +bool bdrv_has_dirty_bitmap(BlockDriverState *bs, const BdrvDirtyBitmap *bitmap); + #endif -- 1.8.3.1