From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 25/49] mips: use MIPSCPU instead of CPUMIPSState
Date: Wed, 16 Mar 2016 11:46:35 +0100 [thread overview]
Message-ID: <1458125219-131698-26-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1458125219-131698-1-git-send-email-pbonzini@redhat.com>
This changes a cpu.h dependency into a cpu-qom.h dependency.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/mips/cputimer.c | 4 +++-
hw/mips/mips_fulong2e.c | 4 ++--
hw/mips/mips_int.c | 3 ++-
hw/mips/mips_jazz.c | 4 ++--
hw/mips/mips_malta.c | 9 ++++-----
hw/mips/mips_mipssim.c | 4 ++--
hw/mips/mips_r4k.c | 4 ++--
include/hw/mips/cpudevs.h | 7 +++++--
8 files changed, 22 insertions(+), 17 deletions(-)
diff --git a/hw/mips/cputimer.c b/hw/mips/cputimer.c
index efb227d..8a166b3 100644
--- a/hw/mips/cputimer.c
+++ b/hw/mips/cputimer.c
@@ -151,8 +151,10 @@ static void mips_timer_cb (void *opaque)
env->CP0_Count--;
}
-void cpu_mips_clock_init (CPUMIPSState *env)
+void cpu_mips_clock_init (MIPSCPU *cpu)
{
+ CPUMIPSState *env = &cpu->env;
+
/*
* If we're in KVM mode, don't create the periodic timer, that is handled in
* kernel.
diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
index bdb716e7..889cdc7 100644
--- a/hw/mips/mips_fulong2e.c
+++ b/hw/mips/mips_fulong2e.c
@@ -334,8 +334,8 @@ static void mips_fulong2e_init(MachineState *machine)
}
/* Init internal devices */
- cpu_mips_irq_init_cpu(env);
- cpu_mips_clock_init(env);
+ cpu_mips_irq_init_cpu(cpu);
+ cpu_mips_clock_init(cpu);
/* North bridge, Bonito --> IP2 */
pci_bus = bonito_init((qemu_irq *)&(env->irq[2]));
diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c
index 59081f9..48192d2 100644
--- a/hw/mips/mips_int.c
+++ b/hw/mips/mips_int.c
@@ -58,8 +58,9 @@ static void cpu_mips_irq_request(void *opaque, int irq, int level)
}
}
-void cpu_mips_irq_init_cpu(CPUMIPSState *env)
+void cpu_mips_irq_init_cpu(MIPSCPU *cpu)
{
+ CPUMIPSState *env = &cpu->env;
qemu_irq *qi;
int i;
diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c
index d6d8058..dc7423d 100644
--- a/hw/mips/mips_jazz.c
+++ b/hw/mips/mips_jazz.c
@@ -200,8 +200,8 @@ static void mips_jazz_init(MachineState *machine,
}
/* Init CPU internal devices */
- cpu_mips_irq_init_cpu(env);
- cpu_mips_clock_init(env);
+ cpu_mips_irq_init_cpu(cpu);
+ cpu_mips_clock_init(cpu);
/* Chipset */
rc4030 = rc4030_init(&dmas, &rc4030_dma_mr);
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index 4ff1bb2..468d297 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -977,11 +977,10 @@ void mips_malta_init(MachineState *machine)
fprintf(stderr, "Unable to find CPU definition\n");
exit(1);
}
- env = &cpu->env;
/* Init internal devices */
- cpu_mips_irq_init_cpu(env);
- cpu_mips_clock_init(env);
+ cpu_mips_irq_init_cpu(cpu);
+ cpu_mips_clock_init(cpu);
qemu_register_reset(main_cpu_reset, cpu);
}
cpu = MIPS_CPU(first_cpu);
@@ -1136,8 +1135,8 @@ void mips_malta_init(MachineState *machine)
stl_p(memory_region_get_ram_ptr(bios_copy) + 0x10, 0x00000420);
/* Init internal devices */
- cpu_mips_irq_init_cpu(env);
- cpu_mips_clock_init(env);
+ cpu_mips_irq_init_cpu(cpu);
+ cpu_mips_clock_init(cpu);
/*
* We have a circular dependency problem: pci_bus depends on isa_irq,
diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c
index a2c2a16..1b91195 100644
--- a/hw/mips/mips_mipssim.c
+++ b/hw/mips/mips_mipssim.c
@@ -216,8 +216,8 @@ mips_mipssim_init(MachineState *machine)
}
/* Init CPU internal devices. */
- cpu_mips_irq_init_cpu(env);
- cpu_mips_clock_init(env);
+ cpu_mips_irq_init_cpu(cpu);
+ cpu_mips_clock_init(cpu);
/* Register 64 KB of ISA IO space at 0x1fd00000. */
memory_region_init_alias(isa, NULL, "isa_mmio",
diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c
index 21aca98..16a59c7 100644
--- a/hw/mips/mips_r4k.c
+++ b/hw/mips/mips_r4k.c
@@ -267,8 +267,8 @@ void mips_r4k_init(MachineState *machine)
}
/* Init CPU internal devices */
- cpu_mips_irq_init_cpu(env);
- cpu_mips_clock_init(env);
+ cpu_mips_irq_init_cpu(cpu);
+ cpu_mips_clock_init(cpu);
/* ISA bus: IO space at 0x14000000, mem space at 0x10000000 */
memory_region_init_alias(isa_io, NULL, "isa-io",
diff --git a/include/hw/mips/cpudevs.h b/include/hw/mips/cpudevs.h
index b2626f2..8673daa 100644
--- a/include/hw/mips/cpudevs.h
+++ b/include/hw/mips/cpudevs.h
@@ -1,5 +1,8 @@
#ifndef HW_MIPS_CPUDEVS_H
#define HW_MIPS_CPUDEVS_H
+
+#include "target-mips/cpu-qom.h"
+
/* Definitions for MIPS CPU internal devices. */
/* mips_addr.c */
@@ -9,9 +12,9 @@ uint64_t cpu_mips_kvm_um_phys_to_kseg0(void *opaque, uint64_t addr);
/* mips_int.c */
-void cpu_mips_irq_init_cpu(CPUMIPSState *env);
+void cpu_mips_irq_init_cpu(MIPSCPU *cpu);
/* mips_timer.c */
-void cpu_mips_clock_init(CPUMIPSState *);
+void cpu_mips_clock_init(MIPSCPU *cpu);
#endif
--
1.8.3.1
next prev parent reply other threads:[~2016-03-16 10:47 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 10:46 [Qemu-devel] [PATCH for-2.7 00/49] NEED_CPU_H and cpu.h cleanups Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 01/49] include: move CPU-related definitions out of qemu-common.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 02/49] log: do not use CONFIG_USER_ONLY Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 03/49] hw: explicitly include qemu-common.h and cpu.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 04/49] cpu: make cpu-qom.h only include-able from cpu.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 05/49] target-alpha: make cpu-qom.h not target specific Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 06/49] target-arm: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 07/49] target-cris: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 08/49] target-i386: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 09/49] target-lm32: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 10/49] target-m68k: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 11/49] target-microblaze: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 12/49] target-mips: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 13/49] target-ppc: do not use target_ulong in cpu-qom.h Paolo Bonzini
2016-03-16 13:02 ` Peter Maydell
2016-03-16 10:46 ` [Qemu-devel] [PATCH 14/49] target-ppc: make cpu-qom.h not target specific Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 15/49] target-s390x: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 16/49] target-sh4: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 17/49] target-sparc: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 18/49] target-tricore: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 19/49] target-unicore32: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 20/49] target-xtensa: " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 21/49] arm: include cpu-qom.h in files that require ARMCPU Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 22/49] m68k: include cpu-qom.h in files that require M68KCPU Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 23/49] sh4: include cpu-qom.h in files that require SuperHCPU Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 24/49] alpha: include cpu-qom.h in files that require AlphaCPU Paolo Bonzini
2016-03-16 10:46 ` Paolo Bonzini [this message]
2016-03-16 10:46 ` [Qemu-devel] [PATCH 26/49] ppc: use PowerPCCPU instead of CPUPPCState Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 27/49] arm: remove useless cpu.h inclusion Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 28/49] explicitly include qom/cpu.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 29/49] explicitly include hw/qdev-core.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 30/49] explicitly include linux/kvm.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 31/49] apic: move target-dependent definitions to cpu.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 32/49] include: poison symbols in osdep.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 33/49] hw: do not use VMSTATE_*TL Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 34/49] hw: move CPU state serialization to migration/cpu.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 35/49] hw: cannot include hw/hw.h from user emulation Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 36/49] cpu: move endian-dependent load/store functions to cpu-all.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 37/49] qemu-common: stop including qemu/bswap.h from qemu-common.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 38/49] qemu-common: stop including qemu/host-utils.h " Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 39/49] gdbstub: remove includes from gdbstub-xml.c Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 40/49] dma: do not depend on kvm_enabled() Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 41/49] s390x: move stuff out of cpu.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 42/49] qemu-common: push cpu.h inclusion out of qemu-common.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 43/49] arm: move arm_log_exception into .c file Paolo Bonzini
2016-03-16 11:18 ` Peter Maydell
2016-03-16 10:46 ` [Qemu-devel] [PATCH 44/49] mips: move CP0 functions out of cpu.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 45/49] hw: explicitly include qemu/log.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 46/49] exec: extract exec/tb-context.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 47/49] cpu: move exec-all.h inclusion out of cpu.h Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 48/49] hw: remove pio_addr_t Paolo Bonzini
2016-03-16 11:16 ` Peter Maydell
2016-03-16 11:21 ` Paolo Bonzini
2016-03-16 10:46 ` [Qemu-devel] [PATCH 49/49] hw: clean up hw/hw.h includes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458125219-131698-26-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).