qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com, imammedo@redhat.com
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
	gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 08/15] nvdimm acpi: save arg3 of _DSM method
Date: Thu, 17 Mar 2016 16:32:54 +0800	[thread overview]
Message-ID: <1458203581-59143-9-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1458203581-59143-1-git-send-email-guangrong.xiao@linux.intel.com>

Check if the input Arg3 is valid then store it into ARG3 if it is
needed

Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
 hw/acpi/nvdimm.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 586c02a..38aba3d 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -486,6 +486,7 @@ void nvdimm_init_acpi_state(AcpiNVDIMMState *state, MemoryRegion *io,
 static void nvdimm_build_common_dsm(Aml *dev)
 {
     Aml *method, *ifctx, *function, *dsm_mem, *unpatched, *result_size;
+    Aml *pckg, *pckg_index, *pckg_buf;
     uint8_t byte_list[1];
 
     method = aml_method(NVDIMM_COMMON_DSM, 5, AML_SERIALIZED);
@@ -522,6 +523,25 @@ static void nvdimm_build_common_dsm(Aml *dev)
     aml_append(method, aml_store(aml_arg(2), aml_name("FUNC")));
 
     /*
+     * The fourth parameter (Arg3) of _DSM is a package which contains
+     * a buffer, the layout of the buffer is specified by UUID (Arg0),
+     * Revision ID (Arg1) and Function Index (Arg2) which are documented
+     * in the DSM Spec.
+     */
+    pckg = aml_arg(3);
+    ifctx = aml_if(aml_and(aml_equal(aml_object_type(pckg),
+                   aml_int(4 /* Package */)) /* It is a Package? */,
+                   aml_equal(aml_sizeof(pckg), aml_int(1)) /* 1 element? */,
+                   NULL));
+
+    pckg_index = aml_local(2);
+    pckg_buf = aml_local(3);
+    aml_append(ifctx, aml_store(aml_index(pckg, aml_int(0)), pckg_index));
+    aml_append(ifctx, aml_store(aml_derefof(pckg_index), pckg_buf));
+    aml_append(ifctx, aml_store(pckg_buf, aml_name("ARG3")));
+    aml_append(method, ifctx);
+
+    /*
      * tell QEMU about the real address of DSM memory, then QEMU
      * gets the control and fills the result in DSM memory.
      */
-- 
1.8.3.1

  parent reply	other threads:[~2016-03-17  8:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17  8:32 [Qemu-devel] [PATCH 00/15] NVDIMM: introduce nvdimm label support Xiao Guangrong
2016-03-17  8:32 ` [Qemu-devel] [PATCH 01/15] pc-dimm: get memory region from ->get_memory_region() Xiao Guangrong
2016-03-17  8:32 ` [Qemu-devel] [PATCH 02/15] pc-dimm: introduce realize callback Xiao Guangrong
2016-03-17  8:32 ` [Qemu-devel] [PATCH 03/15] pc-dimm: keep the state of the whole backend memory Xiao Guangrong
2016-03-17  8:32 ` [Qemu-devel] [PATCH 04/15] nvdimm: support nvdimm label Xiao Guangrong
2016-03-17 10:28   ` Stefan Hajnoczi
2016-03-23  3:40     ` Xiao Guangrong
2016-03-17  8:32 ` [Qemu-devel] [PATCH 05/15] acpi: add aml_object_type Xiao Guangrong
2016-03-17  8:32 ` [Qemu-devel] [PATCH 06/15] acpi: add aml_call5 Xiao Guangrong
2016-03-17  8:32 ` [Qemu-devel] [PATCH 07/15] nvdimm acpi: set HDLE properly Xiao Guangrong
2016-03-17  8:32 ` Xiao Guangrong [this message]
2016-03-17  8:32 ` [Qemu-devel] [PATCH 09/15] nvdimm acpi: check UUID Xiao Guangrong
2016-03-17  8:32 ` [Qemu-devel] [PATCH 10/15] nvdimm acpi: abstract the operations for root device and nvdimm devices Xiao Guangrong
2016-03-17 10:35   ` Stefan Hajnoczi
2016-03-23  3:43     ` Xiao Guangrong
2016-03-17  8:32 ` [Qemu-devel] [PATCH 11/15] nvdimm acpi: check revision Xiao Guangrong
2016-03-17  8:32 ` [Qemu-devel] [PATCH 12/15] nvdimm acpi: support Get Namespace Label Size function Xiao Guangrong
2016-03-17 10:58   ` Stefan Hajnoczi
2016-03-23  3:46     ` Xiao Guangrong
2016-03-17  8:32 ` [Qemu-devel] [PATCH 13/15] nvdimm acpi: support Get Namespace Label Data function Xiao Guangrong
2016-03-17  8:33 ` [Qemu-devel] [PATCH 14/15] nvdimm acpi: support Set " Xiao Guangrong
2016-03-17  8:33 ` [Qemu-devel] [PATCH 15/15] docs: add NVDIMM ACPI documentation Xiao Guangrong
2016-03-17 10:04 ` [Qemu-devel] [PATCH 00/15] NVDIMM: introduce nvdimm label support Stefan Hajnoczi
2016-03-22 15:37   ` Dan Williams
2016-03-22 20:30     ` Stefan Hajnoczi
2016-03-23  2:46       ` Xiao Guangrong
2016-03-23 16:48         ` Stefan Hajnoczi
2016-03-22 11:17 ` Michael S. Tsirkin
2016-03-23  3:47   ` Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458203581-59143-9-git-send-email-guangrong.xiao@linux.intel.com \
    --to=guangrong.xiao@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@kernel.org \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).