From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agTVm-00052P-In for qemu-devel@nongnu.org; Thu, 17 Mar 2016 04:42:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agTVj-00044i-UB for qemu-devel@nongnu.org; Thu, 17 Mar 2016 04:42:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agTVj-00043s-O9 for qemu-devel@nongnu.org; Thu, 17 Mar 2016 04:42:27 -0400 Message-ID: <1458204143.26199.8.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 17 Mar 2016 09:42:23 +0100 In-Reply-To: <56E9A75D.60603@redhat.com> References: <20160316181541.GG12454@HEDWIG.INI.CMU.EDU> <56E9A75D.60603@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: pbonzini@redhat.com, "Gabriel L. Somlo" , qemu-devel@nongnu.org, armbru@redhat.com, mst@redhat.com Hi, > > Having a mis-use of this feature become "institutionalized" over time w= as > > seen as a low/negligible risk at the time. Do we have any new reasons > > to worry about it ? >=20 > OVMF uses this feature for a few flags. They are all called > "opt/ovmf/...". I followed the advice in "docs/specs/fw_cfg.txt" (which > shouldn't be surprising since I seem to have reviewed every patch for > that file): seabios has a few flags too, in etc/. Some of them are supported directly by qemu (such as setting the boot menu delay). Others are not, and I'd like to be able to use -fw_cfg for them for testing/debugging (any use cases beyond that should be supported by adding a less obscure way to set them to qemu, similar to the boot delay). Oh, and that'll most likely be more seabios testing than qemu testing, so why require me build a special qemu version for that? On the ovmf flags: What kind of flags are there? Anything a normal user might want to set? cheers, Gerd