qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, mst@redhat.com, borntraeger@de.ibm.com,
	stefanha@redhat.com, Cornelia Huck <cornelia.huck@de.ibm.com>,
	pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH RFC 0/6] virtio: refactor host notifiers
Date: Thu, 17 Mar 2016 11:01:27 +0100	[thread overview]
Message-ID: <1458208893-15949-1-git-send-email-cornelia.huck@de.ibm.com> (raw)

As discussed in the virtio-blk dataplane start/stop thread, the
various transports contain a lot of similar/identical boilerplate
code for setting up ioeventfds. This makes the code hard to follow.

Let's drag all of the common handling into the virtio-bus layer,
hopefully reducing both the boilerplate code and the number of
indirections.

This RFC patchset is the result of hacking this up quickly, and I
was rather surprised that it did not die immediately on my s390
system (which is all I 'tested'). So be warned :)

Feedback about the approach and the interface would be good.

Cornelia Huck (6):
  virtio-bus: common ioeventfd infrastructure
  virtio-bus: have callers tolerate new host notifier api
  virtio-ccw: convert to ioeventfd callbacks
  virtio-pci: convert to ioeventfd callbacks
  virtio-mmio: convert to ioeventfd callbacks
  virtio-bus: remove old set_host_notifier callback

 hw/block/dataplane/virtio-blk.c |   6 +-
 hw/s390x/virtio-ccw.c           | 133 ++++++++++++++--------------------------
 hw/scsi/virtio-scsi-dataplane.c |   9 ++-
 hw/virtio/vhost.c               |  13 ++--
 hw/virtio/virtio-bus.c          | 108 ++++++++++++++++++++++++++++++++
 hw/virtio/virtio-mmio.c         | 128 +++++++++++++-------------------------
 hw/virtio/virtio-pci.c          | 124 +++++++++++++------------------------
 include/hw/virtio/virtio-bus.h  |  15 ++++-
 8 files changed, 263 insertions(+), 273 deletions(-)

-- 
2.6.5

             reply	other threads:[~2016-03-17 10:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 10:01 Cornelia Huck [this message]
2016-03-17 10:01 ` [Qemu-devel] [PATCH RFC 1/6] virtio-bus: common ioeventfd infrastructure Cornelia Huck
2016-03-22  0:24   ` Fam Zheng
2016-03-22  8:08     ` Cornelia Huck
2016-03-24 11:20   ` Michael S. Tsirkin
2016-03-24 11:30     ` Cornelia Huck
2016-03-17 10:01 ` [Qemu-devel] [PATCH RFC 2/6] virtio-bus: have callers tolerate new host notifier api Cornelia Huck
2016-03-17 10:01 ` [Qemu-devel] [PATCH RFC 3/6] virtio-ccw: convert to ioeventfd callbacks Cornelia Huck
2016-03-17 10:01 ` [Qemu-devel] [PATCH RFC 4/6] virtio-pci: " Cornelia Huck
2016-03-17 10:01 ` [Qemu-devel] [PATCH RFC 5/6] virtio-mmio: " Cornelia Huck
2016-03-17 10:01 ` [Qemu-devel] [PATCH RFC 6/6] virtio-bus: remove old set_host_notifier callback Cornelia Huck
2016-03-21 15:02 ` [Qemu-devel] [PATCH RFC 0/6] virtio: refactor host notifiers Stefan Hajnoczi
2016-03-23  9:34 ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458208893-15949-1-git-send-email-cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=famz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).