From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1agV4y-0008DZ-A9
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 06:22:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1agV4s-0000nL-Ga
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 06:22:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50428)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1agV4s-0000nD-BA
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 06:22:50 -0400
Message-ID: <1458210166.26199.26.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 17 Mar 2016 11:22:46 +0100
In-Reply-To: <56EA7C2C.6070905@redhat.com>
References: <20160316181541.GG12454@HEDWIG.INI.CMU.EDU>
	<56E9A75D.60603@redhat.com> <1458204143.26199.8.camel@redhat.com>
	<56EA7C2C.6070905@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg
 without opt/
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: pbonzini@redhat.com, "Gabriel L. Somlo" <somlo@cmu.edu>, qemu-devel@nongnu.org, armbru@redhat.com, mst@redhat.com

  Hi,

> Occasionally, yes.
>=20
> - "opt/ovmf/PcdPropertiesTableEnable" controls whether the "properties

> - "opt/ovmf/PcdSetNxForStack" controls whether the stack is made

> - "opt/ovmf/X-PciMmio64Mb" controls the size of the range from which the

> In downstream, we have two more (same purpose but separately for ARM and
> x86):
> - opt/aavmf/PcdResizeXterm
> - opt/ovmf/PcdResizeXterm
>=20
> - Another flag I might expose later is "PcdHiiOsRuntimeSupport". This

I think we should probably move those out of the opt/ namespace space,
as this is reserved for user-defined files.

I think either "etc/efi/" or "efi/" is useful (so we don't have
different names on ovmf and aavmf).  Possibly add "pcd/".  Maybe even
support setting *any* pcd via "efi/pcd/$name" (just an idea, not sure
whenever that is useful and is possible without being too invasive).

> - "opt/ovmf/X-PciMmio64Mb" controls the size of the range from which=20

Hmm.  Leave as-is for now I'd say.  If we decide to keep it we should
probably rename it and place it below etc/, next to reserved-memory-end.
Export the size in bytes, like reserved-memory-end does.  Add an option
to qemu to set it, so you can specify the size as "32G" using the
standard qemu size parser.

cheers,
  Gerd