From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agaID-0001Y8-6k for qemu-devel@nongnu.org; Thu, 17 Mar 2016 11:56:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agaIC-0001fB-BP for qemu-devel@nongnu.org; Thu, 17 Mar 2016 11:56:57 -0400 From: Kevin Wolf Date: Thu, 17 Mar 2016 16:56:15 +0100 Message-Id: <1458230202-29136-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1458230202-29136-1-git-send-email-kwolf@redhat.com> References: <1458230202-29136-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 02/29] block: Fix memory leak in hmp_drive_add_node() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org hmp_drive_add_node() leaked qdict in the error path when no node-name is specified. Signed-off-by: Kevin Wolf Reviewed-by: Markus Armbruster --- blockdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/blockdev.c b/blockdev.c index e7b8676..50410bf 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3898,6 +3898,7 @@ void hmp_drive_add_node(Monitor *mon, const char *optstr) qdict = qemu_opts_to_qdict(opts, NULL); if (!qdict_get_try_str(qdict, "node-name")) { + QDECREF(qdict); error_report("'node-name' needs to be specified"); goto out; } -- 1.8.3.1