From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agbXv-0006j5-9R for qemu-devel@nongnu.org; Thu, 17 Mar 2016 13:17:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agbXq-00056M-Aj for qemu-devel@nongnu.org; Thu, 17 Mar 2016 13:17:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agbXq-00056D-55 for qemu-devel@nongnu.org; Thu, 17 Mar 2016 13:17:10 -0400 Message-ID: <1458235026.26199.45.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 17 Mar 2016 18:17:06 +0100 In-Reply-To: <56EAB17A.1000400@redhat.com> References: <1458053080-29170-1-git-send-email-mst@redhat.com> <87fuvpv2jv.fsf@blackfin.pond.sub.org> <20160317143531-mutt-send-email-mst@redhat.com> <56EAB17A.1000400@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, "Gabriel L. Somlo" , Laszlo Ersek , Markus Armbruster , "Michael S. Tsirkin" Hi, > Alternative: fail on: >=20 > - a blacklist of etc/* files including etc/system-states, > etc/smbios/smbios-tables, etc/smbios/smbios-anchor, > etc/reserved-memory-end, etc/pvpanic-port, etc/e820, and possibly > etc/boot-menu-wait I think that fails already because qemu throws an error on duplicate firmware entries. > Likewise SeaBIOS would switch from etc/ to an org.seabios/ prefix (for > stuff usable from both Coreboot and QEMU, e.g. > org.seabios/bootsplash.bmp) or org.qemu/ (for stuff that is specific to > QEMU). Do we really want shuffle around stuff like this? It means we have to support both paths in both firmware and qemu for a quite a while for compatibility reasons. (moving around opt/ovmf/ has this issue too, even though to a lesser extend as there isn't stuff as critical as acpi tables or boot order). Also note that most stuff in etc/ is used by all firmwares, so moving this to org.seabios looks pointless to me, especially as things might change over time (i.e. ovmf starting to use cfg options it used to ignore first, which is the case for etc/boot-menu-wait IIRC, so it started as seabios only but isn't any more). Also note that the fw_cfg layout is modeled a bit after cbfs (coreboot filesystem) which is provided by coreboot and used by seabios. That'll cause trouble too if we try to redefine the paths. cheers, Gerd