qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v6 06/16] qapi-event: Drop qmp_output_get_qobject() null check
Date: Thu, 17 Mar 2016 16:48:31 -0600	[thread overview]
Message-ID: <1458254921-17042-7-git-send-email-eblake@redhat.com> (raw)
In-Reply-To: <1458254921-17042-1-git-send-email-eblake@redhat.com>

qmp_output_get_qobject() was changed never to return null some time
ago (in commit 6c2f9a15), but the qapi_event_send_FOO() functions
still check.  Clean that up:

|@@ -28,7 +28,6 @@ void qapi_event_send_acpi_device_ost(ACP
|     QMPEventFuncEmit emit;
|     QmpOutputVisitor *qov;
|     Visitor *v;
|-    QObject *obj;
|
|     emit = qmp_event_get_func_emit();
|     if (!emit) {
|@@ -54,10 +53,7 @@ out_obj:
|         goto out;
|     }
|
|-    obj = qmp_output_get_qobject(qov);
|-    g_assert(obj);
|-
|-    qdict_put_obj(qmp, "data", obj);
|+    qdict_put_obj(qmp, "data", qmp_output_get_qobject(qov));
|     emit(QAPI_EVENT_ACPI_DEVICE_OST, qmp, &err);
|
| out:

Signed-off-by: Eric Blake <eblake@redhat.com>

---
v6: retitle, reduce scope, improve commit message
v5: new patch
---
 scripts/qapi-event.py | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py
index c03cb78..27af206 100644
--- a/scripts/qapi-event.py
+++ b/scripts/qapi-event.py
@@ -43,7 +43,6 @@ def gen_event_send(name, arg_type):
         ret += mcgen('''
     QmpOutputVisitor *qov;
     Visitor *v;
-    QObject *obj;

 ''')

@@ -77,10 +76,7 @@ out_obj:
         goto out;
     }

-    obj = qmp_output_get_qobject(qov);
-    g_assert(obj);
-
-    qdict_put_obj(qmp, "data", obj);
+    qdict_put_obj(qmp, "data", qmp_output_get_qobject(qov));
 ''')

     ret += mcgen('''
-- 
2.5.0

  parent reply	other threads:[~2016-03-17 22:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 22:48 [Qemu-devel] [PATCH v6 00/16] easier unboxed visits/qapi implicit types Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 01/16] qapi: Assert in places where variants are not handled Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 02/16] qapi: Fix command with named empty argument type Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 03/16] qapi: Make c_type() more OO-like Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 04/16] qapi: Adjust names of implicit types Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 05/16] qapi: Emit implicit structs in generated C Eric Blake
2016-03-17 22:48 ` Eric Blake [this message]
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 07/16] qapi-event: Utilize implicit struct visits Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 08/16] qapi-commands: " Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 09/16] qapi-commands: Inline single-use helpers of gen_marshal() Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 10/16] qapi: Inline gen_visit_members() into lone caller Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 11/16] qapi: Drop unused c_null() Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 12/16] qapi: Don't special-case simple union wrappers Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 13/16] qapi: Make BlockdevOptions doc example closer to reality Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 14/16] qapi: Allow anonymous base for flat union Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 15/16] qapi: Use anonymous bases in QMP flat unions Eric Blake
2016-03-17 22:48 ` [Qemu-devel] [PATCH v6 16/16] qapi: Consolidate object visitors Eric Blake
2016-03-18  7:47   ` Markus Armbruster
2016-03-18 10:01 ` [Qemu-devel] [PATCH v6 00/16] easier unboxed visits/qapi implicit types Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458254921-17042-7-git-send-email-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).