* [Qemu-devel] [PATCH] usb: fix unbound stack warning for inotify_watchfn
@ 2016-03-09 6:07 Peter Xu
2016-03-09 7:56 ` Paolo Bonzini
2016-03-18 12:56 ` Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Peter Xu @ 2016-03-09 6:07 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, kraxel, peterx, peter.maydell
Signed-off-by: Peter Xu <peterx@redhat.com>
---
hw/usb/dev-mtp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 7391783..76ad64e 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -433,12 +433,11 @@ static void inotify_watchfn(void *arg)
MTPState *s = arg;
ssize_t bytes;
/* From the man page: atleast one event can be read */
- int len = sizeof(struct inotify_event) + NAME_MAX + 1;
int pos;
- char buf[len];
+ char buf[sizeof(struct inotify_event) + NAME_MAX + 1];
for (;;) {
- bytes = read(s->inotifyfd, buf, len);
+ bytes = read(s->inotifyfd, buf, sizeof(buf));
pos = 0;
if (bytes <= 0) {
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] usb: fix unbound stack warning for inotify_watchfn
2016-03-09 6:07 [Qemu-devel] [PATCH] usb: fix unbound stack warning for inotify_watchfn Peter Xu
@ 2016-03-09 7:56 ` Paolo Bonzini
2016-03-18 12:56 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2016-03-09 7:56 UTC (permalink / raw)
To: Peter Xu, qemu-devel; +Cc: peter.maydell, kraxel
On 09/03/2016 07:07, Peter Xu wrote:
> - char buf[len];
> + char buf[sizeof(struct inotify_event) + NAME_MAX + 1];
>
> for (;;) {
> - bytes = read(s->inotifyfd, buf, len);
> + bytes = read(s->inotifyfd, buf, sizeof(buf));
sizeof is good here, since read takes a size in bytes.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] usb: fix unbound stack warning for inotify_watchfn
2016-03-09 6:07 [Qemu-devel] [PATCH] usb: fix unbound stack warning for inotify_watchfn Peter Xu
2016-03-09 7:56 ` Paolo Bonzini
@ 2016-03-18 12:56 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2016-03-18 12:56 UTC (permalink / raw)
To: Peter Xu; +Cc: pbonzini, qemu-devel, peter.maydell
On Mi, 2016-03-09 at 14:07 +0800, Peter Xu wrote:
> Signed-off-by: Peter Xu <peterx@redhat.com>
added to usb queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-18 12:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-09 6:07 [Qemu-devel] [PATCH] usb: fix unbound stack warning for inotify_watchfn Peter Xu
2016-03-09 7:56 ` Paolo Bonzini
2016-03-18 12:56 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).