From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agxmQ-0006kC-Dz for qemu-devel@nongnu.org; Fri, 18 Mar 2016 13:01:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agxmM-0008Ad-Ka for qemu-devel@nongnu.org; Fri, 18 Mar 2016 13:01:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agxmM-0008A8-Cy for qemu-devel@nongnu.org; Fri, 18 Mar 2016 13:01:38 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id F255EC00124A for ; Fri, 18 Mar 2016 17:01:37 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2IH1ZTU010124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 18 Mar 2016 13:01:37 -0400 From: Markus Armbruster Date: Fri, 18 Mar 2016 18:01:25 +0100 Message-Id: <1458320487-19603-39-git-send-email-armbru@redhat.com> In-Reply-To: <1458320487-19603-1-git-send-email-armbru@redhat.com> References: <1458320487-19603-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 38/40] ivshmem: Drop ivshmem property x-memdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Use ivshmem-plain instead. Signed-off-by: Markus Armbruster Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <1458066895-20632-39-git-send-email-armbru@redhat.com> --- hw/misc/ivshmem.c | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 49e363e..90930f2 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -1197,17 +1197,12 @@ static void ivshmem_realize(PCIDevice *dev, Error= **errp) " or ivshmem-doorbell instead"); } =20 - if (!!s->server_chr + !!s->shmobj + !!s->hostmem !=3D 1) { - error_setg(errp, - "You must specify either 'shm', 'chardev' or 'x-memde= v'"); + if (!!s->server_chr + !!s->shmobj !=3D 1) { + error_setg(errp, "You must specify either 'shm' or 'chardev'"); return; } =20 - if (s->hostmem) { - if (s->sizearg) { - g_warning("size argument ignored with hostmem"); - } - } else if (s->sizearg =3D=3D NULL) { + if (s->sizearg =3D=3D NULL) { s->legacy_size =3D 4 << 20; /* 4 MB default */ } else { char *end; @@ -1247,17 +1242,6 @@ static void ivshmem_realize(PCIDevice *dev, Error = **errp) ivshmem_common_realize(dev, errp); } =20 -static void ivshmem_init(Object *obj) -{ - IVShmemState *s =3D IVSHMEM(obj); - - object_property_add_link(obj, "x-memdev", TYPE_MEMORY_BACKEND, - (Object **)&s->hostmem, - ivshmem_check_memdev_is_busy, - OBJ_PROP_LINK_UNREF_ON_RELEASE, - &error_abort); -} - static void ivshmem_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -1274,7 +1258,6 @@ static const TypeInfo ivshmem_info =3D { .name =3D TYPE_IVSHMEM, .parent =3D TYPE_IVSHMEM_COMMON, .instance_size =3D sizeof(IVShmemState), - .instance_init =3D ivshmem_init, .class_init =3D ivshmem_class_init, }; =20 --=20 2.4.3