From: marcin.krzeminski@nokia.com
To: qemu-devel@nongnu.org
Cc: crosthwaitepeter@gmail.com, clg@fr.ibm.com,
rfsw-patches@mlist.nsn-inter.net, pawel.lenkow@itlen.com,
marcin.krzeminski@nokia.com
Subject: [Qemu-devel] [PATCH v5 08/11] block: m25p80: Fast read and 4bytes commands
Date: Sun, 20 Mar 2016 19:28:10 +0100 [thread overview]
Message-ID: <1458498493-13906-9-git-send-email-marcin.krzeminski@nokia.com> (raw)
In-Reply-To: <1458498493-13906-1-git-send-email-marcin.krzeminski@nokia.com>
From: Marcin Krzeminski <marcin.krzeminski@nokia.com>
Adds fast read and 4bytes commands family.
This work is based on Pawel Lenkow patch from v1.
Signed-off-by: Marcin Krzeminski <marcin.krzeminski@nokia.com>
Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
---
hw/block/m25p80.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 46 insertions(+), 4 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index c245531..c0b7b8c 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -243,20 +243,29 @@ typedef enum {
JEDEC_READ = 0x9f,
BULK_ERASE = 0xc7,
- READ = 0x3,
- FAST_READ = 0xb,
+ READ = 0x03,
+ READ4 = 0x13,
+ FAST_READ = 0x0b,
+ FAST_READ4 = 0x0c,
DOR = 0x3b,
+ DOR4 = 0x3c,
QOR = 0x6b,
+ QOR4 = 0x6c,
DIOR = 0xbb,
+ DIOR4 = 0xbc,
QIOR = 0xeb,
+ QIOR4 = 0xec,
- PP = 0x2,
+ PP = 0x02,
+ PP4 = 0x12,
DPP = 0xa2,
QPP = 0x32,
ERASE_4K = 0x20,
+ ERASE4_4K = 0x21,
ERASE_32K = 0x52,
ERASE_SECTOR = 0xd8,
+ ERASE4_SECTOR = 0xdc,
EN_4BYTE_ADDR = 0xB7,
EX_4BYTE_ADDR = 0xE9,
@@ -379,6 +388,7 @@ static void flash_erase(Flash *s, int offset, FlashCMD cmd)
switch (cmd) {
case ERASE_4K:
+ case ERASE4_4K:
len = 4 << 10;
capa_to_assert = ER_4K;
break;
@@ -387,6 +397,7 @@ static void flash_erase(Flash *s, int offset, FlashCMD cmd)
capa_to_assert = ER_32K;
break;
case ERASE_SECTOR:
+ case ERASE4_SECTOR:
len = s->pi->sector_size;
break;
case BULK_ERASE:
@@ -445,7 +456,20 @@ void flash_write8(Flash *s, uint64_t addr, uint8_t data)
static inline int get_addr_length(Flash *s)
{
- return s->four_bytes_address_mode ? 4 : 3;
+ switch (s->cmd_in_progress) {
+ case PP4:
+ case READ4:
+ case QIOR4:
+ case ERASE4_4K:
+ case ERASE4_SECTOR:
+ case FAST_READ4:
+ case DOR4:
+ case QOR4:
+ case DIOR4:
+ return 4;
+ default:
+ return s->four_bytes_address_mode ? 4 : 3;
+ }
}
static void complete_collecting_data(Flash *s)
@@ -469,19 +493,28 @@ static void complete_collecting_data(Flash *s)
case DPP:
case QPP:
case PP:
+ case PP4:
s->state = STATE_PAGE_PROGRAM;
break;
case READ:
+ case READ4:
case FAST_READ:
+ case FAST_READ4:
case DOR:
+ case DOR4:
case QOR:
+ case QOR4:
case DIOR:
+ case DIOR4:
case QIOR:
+ case QIOR4:
s->state = STATE_READ;
break;
case ERASE_4K:
+ case ERASE4_4K:
case ERASE_32K:
case ERASE_SECTOR:
+ case ERASE4_SECTOR:
flash_erase(s, s->cur_addr, s->cmd_in_progress);
break;
case WRSR:
@@ -568,12 +601,16 @@ static void decode_new_cmd(Flash *s, uint32_t value)
switch (value) {
case ERASE_4K:
+ case ERASE4_4K:
case ERASE_32K:
case ERASE_SECTOR:
+ case ERASE4_SECTOR:
case READ:
+ case READ4:
case DPP:
case QPP:
case PP:
+ case PP4:
s->needed_bytes = get_addr_length(s);
s->pos = 0;
s->len = 0;
@@ -581,8 +618,11 @@ static void decode_new_cmd(Flash *s, uint32_t value)
break;
case FAST_READ:
+ case FAST_READ4:
case DOR:
+ case DOR4:
case QOR:
+ case QOR4:
s->needed_bytes = get_addr_length(s);
if (((s->pi->jedec >> 16) & 0xFF) == JEDEC_NUMONYX) {
/* Dummy cycles modeled with bytes writes instead of bits */
@@ -594,6 +634,7 @@ static void decode_new_cmd(Flash *s, uint32_t value)
break;
case DIOR:
+ case DIOR4:
switch ((s->pi->jedec >> 16) & 0xFF) {
case JEDEC_WINBOND:
case JEDEC_SPANSION:
@@ -610,6 +651,7 @@ static void decode_new_cmd(Flash *s, uint32_t value)
break;
case QIOR:
+ case QIOR4:
switch ((s->pi->jedec >> 16) & 0xFF) {
case JEDEC_WINBOND:
case JEDEC_SPANSION:
--
2.5.0
next prev parent reply other threads:[~2016-03-20 18:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 18:28 [Qemu-devel] [PATCH v5 00/11] Support for N25Q256/512 and AT25128/256 marcin.krzeminski
2016-03-20 18:28 ` [Qemu-devel] [PATCH v5 01/11] block: m25p80: Removed unused variable marcin.krzeminski
2016-03-20 18:28 ` [Qemu-devel] [PATCH v5 02/11] block: m25p80: RESET_ENABLE and RESET_MEMORY commands marcin.krzeminski
2016-03-21 17:02 ` Cédric Le Goater
2016-03-21 17:38 ` [Qemu-devel] ODP: " Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-03-20 18:28 ` [Qemu-devel] [PATCH v5 03/11] block: m25p80: Widen flags variable marcin.krzeminski
2016-03-20 18:28 ` [Qemu-devel] [PATCH v5 04/11] block: m25p80: Extend address mode marcin.krzeminski
2016-03-20 18:28 ` [Qemu-devel] [PATCH v5 05/11] block: m25p80: 4byte " marcin.krzeminski
2016-03-21 17:47 ` Cédric Le Goater
2016-03-21 18:00 ` [Qemu-devel] ODP: " Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-03-20 18:28 ` [Qemu-devel] [PATCH v5 06/11] block: m25p80: Add configuration registers marcin.krzeminski
2016-03-20 18:28 ` [Qemu-devel] [PATCH v5 07/11] block: m25p80: Dummy cycles for N25Q256/512 marcin.krzeminski
2016-03-20 18:28 ` marcin.krzeminski [this message]
2016-03-20 18:28 ` [Qemu-devel] [PATCH v5 09/11] block: m25p80: Implemented FSR register marcin.krzeminski
2016-03-20 18:28 ` [Qemu-devel] [PATCH v5 10/11] block: m25p80: n25q256a/n25q512a models marcin.krzeminski
2016-03-20 18:28 ` [Qemu-devel] [PATCH v5 11/11] block: m25p80: at25128a/at25256a models marcin.krzeminski
2016-03-23 15:30 ` [Qemu-devel] [PATCH v5 00/11] Support for N25Q256/512 and AT25128/256 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458498493-13906-9-git-send-email-marcin.krzeminski@nokia.com \
--to=marcin.krzeminski@nokia.com \
--cc=clg@fr.ibm.com \
--cc=crosthwaitepeter@gmail.com \
--cc=pawel.lenkow@itlen.com \
--cc=qemu-devel@nongnu.org \
--cc=rfsw-patches@mlist.nsn-inter.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).