From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahuo1-0006PH-18 for qemu-devel@nongnu.org; Mon, 21 Mar 2016 04:03:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahunw-0005UQ-Pr for qemu-devel@nongnu.org; Mon, 21 Mar 2016 04:03:16 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:59595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahunw-0005Tz-KD for qemu-devel@nongnu.org; Mon, 21 Mar 2016 04:03:12 -0400 Received: from pova.uni-paderborn.de ([131.234.189.23] helo=localhost.localdomain) by mail.uni-paderborn.de with esmtp (Exim 4.84_2 zuban) id 1ahunu-0001tV-K9 for qemu-devel@nongnu.org; Mon, 21 Mar 2016 09:03:10 +0100 Received: from mail.uni-paderborn.de by pova with queue id 1075682-2 for qemu-devel@nongnu.org; Mon, 21 Mar 2016 08:03:10 GMT From: Bastian Koppelmann Date: Mon, 21 Mar 2016 09:03:01 +0100 Message-Id: <1458547383-23102-2-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1458547383-23102-1-git-send-email-kbastian@mail.uni-paderborn.de> References: <1458547383-23102-1-git-send-email-kbastian@mail.uni-paderborn.de> Subject: [Qemu-devel] [PATCH v2 1/3] target-tricore: add missing break in insn decode switch stmt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kbastian@mail.uni-paderborn.de After decoding/translating a RRR_DIVIDE/RRRR_EXTRACT_INSERT type instruction we would simply fall through and would decode/translate another unintended RRR2_MADD/RRRW_EXTRACT_INSERT instruction. Signed-off-by: Bastian Koppelmann --- v1 -> v2: - Add second missing break target-tricore/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index d13e5c8..66f798a 100644 --- a/target-tricore/translate.c +++ b/target-tricore/translate.c @@ -8632,6 +8632,7 @@ static void decode_32Bit_opc(CPUTriCoreState *env, DisasContext *ctx) break; case OPCM_32_RRR_DIVIDE: decode_rrr_divide(env, ctx); + break; /* RRR2 Format */ case OPCM_32_RRR2_MADD: decode_rrr2_madd(env, ctx); @@ -8661,6 +8662,7 @@ static void decode_32Bit_opc(CPUTriCoreState *env, DisasContext *ctx) /* RRRR format */ case OPCM_32_RRRR_EXTRACT_INSERT: decode_rrrr_extract_insert(env, ctx); + break; /* RRRW format */ case OPCM_32_RRRW_EXTRACT_INSERT: decode_rrrw_extract_insert(env, ctx); -- 2.7.4