* [Qemu-devel] [PULL 0/6] usb patch queue
@ 2016-03-21 11:10 Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 1/6] usb: Fix compilation for Windows Gerd Hoffmann
` (6 more replies)
0 siblings, 7 replies; 16+ messages in thread
From: Gerd Hoffmann @ 2016-03-21 11:10 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Hi,
Here comes the usb patch queue, with a bunch of usb bugixes accumulated
over the last weeks.
If you have anything outstanding usb patches which are not in here,
please resend (exception: the xen host adapter patches which are waiting
for review from xen people).
please pull,
Gerd
The following changes since commit 6741d38ad0f2405a6e999ebc9550801b01aca479:
Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2016-03-17 15:59:42 +0000)
are available in the git repository at:
git://git.kraxel.org/qemu tags/pull-usb-20160321-1
for you to fetch changes up to dff0367cf66f489aa772320fa2937a8cac1ca30d:
usb: ehci: add capability mmio write function (2016-03-18 14:20:39 +0100)
----------------------------------------------------------------
usb: bugfix collection.
----------------------------------------------------------------
Matthew Fortune (1):
hw/usb/dev-mtp: Guard inotify usage with CONFIG_INOTIFY1
Peter Xu (3):
usb: fix unbounded stack warning for xhci_dma_write_u32s
usb: fix unbound stack usage for usb_mtp_add_str
usb: fix unbound stack warning for inotify_watchfn
Prasad J Pandit (1):
usb: ehci: add capability mmio write function
Stefan Weil (1):
usb: Fix compilation for Windows
hw/usb/dev-mtp.c | 29 +++++++++++++++--------------
hw/usb/hcd-ehci.c | 6 ++++++
hw/usb/hcd-xhci.c | 6 ++++--
hw/usb/redirect.c | 4 +++-
4 files changed, 28 insertions(+), 17 deletions(-)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Qemu-devel] [PULL 1/6] usb: Fix compilation for Windows
2016-03-21 11:10 [Qemu-devel] [PULL 0/6] usb patch queue Gerd Hoffmann
@ 2016-03-21 11:10 ` Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 2/6] usb: fix unbounded stack warning for xhci_dma_write_u32s Gerd Hoffmann
` (5 subsequent siblings)
6 siblings, 0 replies; 16+ messages in thread
From: Gerd Hoffmann @ 2016-03-21 11:10 UTC (permalink / raw)
To: qemu-devel; +Cc: Stefan Weil, Gerd Hoffmann
From: Stefan Weil <sw@weilnetz.de>
Mingw-w64 does not provide sys/ioctl.h and Linux builds don't need it,
so remove that include statement.
ERROR is defined by wingdi.h (included via windows.h). Undefine it before
it is redefined to avoid a compiler warning / error.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-id: 1458159439-32322-1-git-send-email-sw@weilnetz.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/redirect.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 38a5393..cbcc218 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -34,12 +34,14 @@
#include "qemu/iov.h"
#include "sysemu/char.h"
-#include <sys/ioctl.h>
#include <usbredirparser.h>
#include <usbredirfilter.h>
#include "hw/usb.h"
+/* ERROR is defined below. Remove any previous definition. */
+#undef ERROR
+
#define MAX_ENDPOINTS 32
#define NO_INTERFACE_INFO 255 /* Valid interface_count always <= 32 */
#define EP2I(ep_address) (((ep_address & 0x80) >> 3) | (ep_address & 0x0f))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Qemu-devel] [PULL 2/6] usb: fix unbounded stack warning for xhci_dma_write_u32s
2016-03-21 11:10 [Qemu-devel] [PULL 0/6] usb patch queue Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 1/6] usb: Fix compilation for Windows Gerd Hoffmann
@ 2016-03-21 11:10 ` Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 3/6] usb: fix unbound stack usage for usb_mtp_add_str Gerd Hoffmann
` (4 subsequent siblings)
6 siblings, 0 replies; 16+ messages in thread
From: Gerd Hoffmann @ 2016-03-21 11:10 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Peter Xu
From: Peter Xu <peterx@redhat.com>
All the callers for xhci_dma_write_u32s() are using mostly 5 * uint32_t
in len. To avoid unbound stack warning for the function, make it
statically allocated, and assert when it's not big enough in the
future.
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-id: 1457661106-9569-1-git-send-email-peterx@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/hcd-xhci.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 44b6f8c..bcde8a2 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -698,11 +698,13 @@ static inline void xhci_dma_write_u32s(XHCIState *xhci, dma_addr_t addr,
uint32_t *buf, size_t len)
{
int i;
- uint32_t tmp[len / sizeof(uint32_t)];
+ uint32_t tmp[5];
+ uint32_t n = len / sizeof(uint32_t);
assert((len % sizeof(uint32_t)) == 0);
+ assert(n <= ARRAY_SIZE(tmp));
- for (i = 0; i < (len / sizeof(uint32_t)); i++) {
+ for (i = 0; i < n; i++) {
tmp[i] = cpu_to_le32(buf[i]);
}
pci_dma_write(PCI_DEVICE(xhci), addr, tmp, len);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Qemu-devel] [PULL 3/6] usb: fix unbound stack usage for usb_mtp_add_str
2016-03-21 11:10 [Qemu-devel] [PULL 0/6] usb patch queue Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 1/6] usb: Fix compilation for Windows Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 2/6] usb: fix unbounded stack warning for xhci_dma_write_u32s Gerd Hoffmann
@ 2016-03-21 11:10 ` Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 4/6] usb: fix unbound stack warning for inotify_watchfn Gerd Hoffmann
` (3 subsequent siblings)
6 siblings, 0 replies; 16+ messages in thread
From: Gerd Hoffmann @ 2016-03-21 11:10 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Peter Xu
From: Peter Xu <peterx@redhat.com>
Use heap instead of stack.
Signed-off-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/dev-mtp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 7391783..62fb7cd 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -718,7 +718,7 @@ static void usb_mtp_add_wstr(MTPData *data, const wchar_t *str)
static void usb_mtp_add_str(MTPData *data, const char *str)
{
uint32_t len = strlen(str)+1;
- wchar_t wstr[len];
+ wchar_t *wstr = g_new(wchar_t, len);
size_t ret;
ret = mbstowcs(wstr, str, len);
@@ -727,6 +727,8 @@ static void usb_mtp_add_str(MTPData *data, const char *str)
} else {
usb_mtp_add_wstr(data, wstr);
}
+
+ g_free(wstr);
}
static void usb_mtp_add_time(MTPData *data, time_t time)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Qemu-devel] [PULL 4/6] usb: fix unbound stack warning for inotify_watchfn
2016-03-21 11:10 [Qemu-devel] [PULL 0/6] usb patch queue Gerd Hoffmann
` (2 preceding siblings ...)
2016-03-21 11:10 ` [Qemu-devel] [PULL 3/6] usb: fix unbound stack usage for usb_mtp_add_str Gerd Hoffmann
@ 2016-03-21 11:10 ` Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 5/6] hw/usb/dev-mtp: Guard inotify usage with CONFIG_INOTIFY1 Gerd Hoffmann
` (2 subsequent siblings)
6 siblings, 0 replies; 16+ messages in thread
From: Gerd Hoffmann @ 2016-03-21 11:10 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Peter Xu
From: Peter Xu <peterx@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1457503640-31473-1-git-send-email-peterx@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/dev-mtp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 62fb7cd..01c5e51 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -433,12 +433,11 @@ static void inotify_watchfn(void *arg)
MTPState *s = arg;
ssize_t bytes;
/* From the man page: atleast one event can be read */
- int len = sizeof(struct inotify_event) + NAME_MAX + 1;
int pos;
- char buf[len];
+ char buf[sizeof(struct inotify_event) + NAME_MAX + 1];
for (;;) {
- bytes = read(s->inotifyfd, buf, len);
+ bytes = read(s->inotifyfd, buf, sizeof(buf));
pos = 0;
if (bytes <= 0) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Qemu-devel] [PULL 5/6] hw/usb/dev-mtp: Guard inotify usage with CONFIG_INOTIFY1
2016-03-21 11:10 [Qemu-devel] [PULL 0/6] usb patch queue Gerd Hoffmann
` (3 preceding siblings ...)
2016-03-21 11:10 ` [Qemu-devel] [PULL 4/6] usb: fix unbound stack warning for inotify_watchfn Gerd Hoffmann
@ 2016-03-21 11:10 ` Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 6/6] usb: ehci: add capability mmio write function Gerd Hoffmann
2016-03-22 17:39 ` [Qemu-devel] [PULL 0/6] usb patch queue Peter Maydell
6 siblings, 0 replies; 16+ messages in thread
From: Gerd Hoffmann @ 2016-03-21 11:10 UTC (permalink / raw)
To: qemu-devel; +Cc: Matthew Fortune, Gerd Hoffmann
From: Matthew Fortune <Matthew.Fortune@imgtec.com>
inotify_init1 usage was guarded by a check for linux but does not
exist on older distributions like CentOS 5 resulting in build
failures.
Signed-off-by: Matthew Fortune <matthew.fortune@imgtec.com>
Message-id: 6D39441BF12EF246A7ABCE6654B023536BB85D4A@hhmail02.hh.imgtec.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/dev-mtp.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 01c5e51..ee2071f 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -14,7 +14,7 @@
#include <dirent.h>
#include <sys/statvfs.h>
-#ifdef __linux__
+#ifdef CONFIG_INOTIFY1
#include <sys/inotify.h>
#include "qemu/main-loop.h"
#endif
@@ -92,7 +92,7 @@ enum {
EP_EVENT,
};
-#ifdef __linux__
+#ifdef CONFIG_INOTIFY1
typedef struct MTPMonEntry MTPMonEntry;
struct MTPMonEntry {
@@ -127,7 +127,7 @@ struct MTPObject {
char *name;
char *path;
struct stat stat;
-#ifdef __linux__
+#ifdef CONFIG_INOTIFY1
/* inotify watch cookie */
int watchfd;
#endif
@@ -152,7 +152,7 @@ struct MTPState {
uint32_t next_handle;
QTAILQ_HEAD(, MTPObject) objects;
-#ifdef __linux__
+#ifdef CONFIG_INOTIFY1
/* inotify descriptor */
int inotifyfd;
QTAILQ_HEAD(events, MTPMonEntry) events;
@@ -400,7 +400,7 @@ static MTPObject *usb_mtp_add_child(MTPState *s, MTPObject *o,
return child;
}
-#ifdef __linux__
+#ifdef CONFIG_INOTIFY1
static MTPObject *usb_mtp_object_lookup_name(MTPObject *parent,
char *name, int len)
{
@@ -592,7 +592,7 @@ static void usb_mtp_object_readdir(MTPState *s, MTPObject *o)
if (!dir) {
return;
}
-#ifdef __linux__
+#ifdef CONFIG_INOTIFY1
int watchfd = usb_mtp_add_watch(s->inotifyfd, o->path);
if (watchfd == -1) {
fprintf(stderr, "usb-mtp: failed to add watch for %s\n", o->path);
@@ -996,7 +996,7 @@ static void usb_mtp_command(MTPState *s, MTPControl *c)
trace_usb_mtp_op_open_session(s->dev.addr);
s->session = c->argv[0];
usb_mtp_object_alloc(s, s->next_handle++, NULL, s->root);
-#ifdef __linux__
+#ifdef CONFIG_INOTIFY1
if (usb_mtp_inotify_init(s)) {
fprintf(stderr, "usb-mtp: file monitoring init failed\n");
}
@@ -1006,7 +1006,7 @@ static void usb_mtp_command(MTPState *s, MTPControl *c)
trace_usb_mtp_op_close_session(s->dev.addr);
s->session = 0;
s->next_handle = 0;
-#ifdef __linux__
+#ifdef CONFIG_INOTIFY1
usb_mtp_inotify_cleanup(s);
#endif
usb_mtp_object_free(s, QTAILQ_FIRST(&s->objects));
@@ -1134,7 +1134,7 @@ static void usb_mtp_handle_reset(USBDevice *dev)
trace_usb_mtp_reset(s->dev.addr);
-#ifdef __linux__
+#ifdef CONFIG_INOTIFY1
usb_mtp_inotify_cleanup(s);
#endif
usb_mtp_object_free(s, QTAILQ_FIRST(&s->objects));
@@ -1297,7 +1297,7 @@ static void usb_mtp_handle_data(USBDevice *dev, USBPacket *p)
}
break;
case EP_EVENT:
-#ifdef __linux__
+#ifdef CONFIG_INOTIFY1
if (!QTAILQ_EMPTY(&s->events)) {
struct MTPMonEntry *e = QTAILQ_LAST(&s->events, events);
uint32_t handle;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Qemu-devel] [PULL 6/6] usb: ehci: add capability mmio write function
2016-03-21 11:10 [Qemu-devel] [PULL 0/6] usb patch queue Gerd Hoffmann
` (4 preceding siblings ...)
2016-03-21 11:10 ` [Qemu-devel] [PULL 5/6] hw/usb/dev-mtp: Guard inotify usage with CONFIG_INOTIFY1 Gerd Hoffmann
@ 2016-03-21 11:10 ` Gerd Hoffmann
2016-03-22 17:39 ` [Qemu-devel] [PULL 0/6] usb patch queue Peter Maydell
6 siblings, 0 replies; 16+ messages in thread
From: Gerd Hoffmann @ 2016-03-21 11:10 UTC (permalink / raw)
To: qemu-devel; +Cc: Prasad J Pandit, Gerd Hoffmann
From: Prasad J Pandit <pjp@fedoraproject.org>
USB Ehci emulation supports host controller capability registers.
But its mmio '.write' function was missing, which lead to a null
pointer dereference issue. Add a do nothing 'ehci_caps_write'
definition to avoid it; Do nothing because capability registers
are Read Only(RO).
Reported-by: Zuozhi Fzz <zuozhi.fzz@alibaba-inc.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-id: 1454072434-16045-1-git-send-email-ppandit@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/hcd-ehci.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 1b50601..0f95d0d 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -895,6 +895,11 @@ static uint64_t ehci_caps_read(void *ptr, hwaddr addr,
return s->caps[addr];
}
+static void ehci_caps_write(void *ptr, hwaddr addr,
+ uint64_t val, unsigned size)
+{
+}
+
static uint64_t ehci_opreg_read(void *ptr, hwaddr addr,
unsigned size)
{
@@ -2315,6 +2320,7 @@ static void ehci_frame_timer(void *opaque)
static const MemoryRegionOps ehci_mmio_caps_ops = {
.read = ehci_caps_read,
+ .write = ehci_caps_write,
.valid.min_access_size = 1,
.valid.max_access_size = 4,
.impl.min_access_size = 1,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [PULL 0/6] usb patch queue
2016-03-21 11:10 [Qemu-devel] [PULL 0/6] usb patch queue Gerd Hoffmann
` (5 preceding siblings ...)
2016-03-21 11:10 ` [Qemu-devel] [PULL 6/6] usb: ehci: add capability mmio write function Gerd Hoffmann
@ 2016-03-22 17:39 ` Peter Maydell
6 siblings, 0 replies; 16+ messages in thread
From: Peter Maydell @ 2016-03-22 17:39 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: QEMU Developers
On 21 March 2016 at 11:10, Gerd Hoffmann <kraxel@redhat.com> wrote:
> Hi,
>
> Here comes the usb patch queue, with a bunch of usb bugixes accumulated
> over the last weeks.
>
> If you have anything outstanding usb patches which are not in here,
> please resend (exception: the xen host adapter patches which are waiting
> for review from xen people).
>
> please pull,
> Gerd
>
> The following changes since commit 6741d38ad0f2405a6e999ebc9550801b01aca479:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2016-03-17 15:59:42 +0000)
>
> are available in the git repository at:
>
>
> git://git.kraxel.org/qemu tags/pull-usb-20160321-1
>
> for you to fetch changes up to dff0367cf66f489aa772320fa2937a8cac1ca30d:
>
> usb: ehci: add capability mmio write function (2016-03-18 14:20:39 +0100)
>
> ----------------------------------------------------------------
> usb: bugfix collection.
>
> ----------------------------------------------------------------
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Qemu-devel] [PULL 0/6] usb patch queue
@ 2017-05-12 12:21 Gerd Hoffmann
2017-05-15 13:30 ` Stefan Hajnoczi
0 siblings, 1 reply; 16+ messages in thread
From: Gerd Hoffmann @ 2017-05-12 12:21 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Hi,
Here comes the usb patch queue, with a bugfix collection and a
documentation update.
please pull,
Gerd
The following changes since commit 76d20ea0f1b26ebd5da2f5fb2fdf3250cde887bb:
Merge remote-tracking branch 'armbru/tags/pull-qapi-2017-05-04-v3' into staging (2017-05-09 15:49:14 -0400)
are available in the git repository at:
git://git.kraxel.org/qemu tags/pull-usb-20170512-1
for you to fetch changes up to aa612b364ecbe1dc034efcabb04526f24e56c145:
hw/usb/dev-serial: Do not try to set vendorid or productid properties (2017-05-12 12:30:23 +0200)
----------------------------------------------------------------
usb: bugfixes, doc update
----------------------------------------------------------------
Gerd Hoffmann (1):
usb-redir: fix stack overflow in usbredir_log_data
Ladi Prosek (3):
xhci: fix logging
usb-hub: clear PORT_STAT_SUSPEND on wakeup
xhci: relax link check
Thomas Huth (2):
qemu-doc: Update to use the new way of attaching USB devices
hw/usb/dev-serial: Do not try to set vendorid or productid properties
docs/qdev-device-use.txt | 6 ++--
hw/usb/dev-hub.c | 1 +
hw/usb/dev-serial.c | 24 ++++---------
hw/usb/hcd-xhci.c | 9 ++---
hw/usb/redirect.c | 13 +------
qemu-doc.texi | 91 +++++++++++++++++++++++++++---------------------
6 files changed, 64 insertions(+), 80 deletions(-)
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [PULL 0/6] usb patch queue
2017-05-12 12:21 Gerd Hoffmann
@ 2017-05-15 13:30 ` Stefan Hajnoczi
0 siblings, 0 replies; 16+ messages in thread
From: Stefan Hajnoczi @ 2017-05-15 13:30 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1706 bytes --]
On Fri, May 12, 2017 at 02:21:52PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> Here comes the usb patch queue, with a bugfix collection and a
> documentation update.
>
> please pull,
> Gerd
>
> The following changes since commit 76d20ea0f1b26ebd5da2f5fb2fdf3250cde887bb:
>
> Merge remote-tracking branch 'armbru/tags/pull-qapi-2017-05-04-v3' into staging (2017-05-09 15:49:14 -0400)
>
> are available in the git repository at:
>
> git://git.kraxel.org/qemu tags/pull-usb-20170512-1
>
> for you to fetch changes up to aa612b364ecbe1dc034efcabb04526f24e56c145:
>
> hw/usb/dev-serial: Do not try to set vendorid or productid properties (2017-05-12 12:30:23 +0200)
>
> ----------------------------------------------------------------
> usb: bugfixes, doc update
>
> ----------------------------------------------------------------
> Gerd Hoffmann (1):
> usb-redir: fix stack overflow in usbredir_log_data
>
> Ladi Prosek (3):
> xhci: fix logging
> usb-hub: clear PORT_STAT_SUSPEND on wakeup
> xhci: relax link check
>
> Thomas Huth (2):
> qemu-doc: Update to use the new way of attaching USB devices
> hw/usb/dev-serial: Do not try to set vendorid or productid properties
>
> docs/qdev-device-use.txt | 6 ++--
> hw/usb/dev-hub.c | 1 +
> hw/usb/dev-serial.c | 24 ++++---------
> hw/usb/hcd-xhci.c | 9 ++---
> hw/usb/redirect.c | 13 +------
> qemu-doc.texi | 91 +++++++++++++++++++++++++++---------------------
> 6 files changed, 64 insertions(+), 80 deletions(-)
>
Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Qemu-devel] [PULL 0/6] usb patch queue
@ 2013-01-14 11:50 Gerd Hoffmann
2013-01-14 18:03 ` Anthony Liguori
0 siblings, 1 reply; 16+ messages in thread
From: Gerd Hoffmann @ 2013-01-14 11:50 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Hi,
The usb patch queue, with coverity fixes. Also makes xhci
cancel inflight transfers on usb device unplug.
please pull,
Gerd
The following changes since commit 63fb2590839162afdf14d7c0ee02d460766c0956:
Merge branch 'target-arm.next' of git://git.linaro.org/people/pmaydell/qemu-arm (2013-01-12 12:47:07 +0000)
are available in the git repository at:
git://git.kraxel.org/qemu usb.76
for you to fetch changes up to 036078475427f2562c8e505f6bb44dbf5d8cbd95:
usb-host: Initialize dev->port the obviously safe way (2013-01-14 12:47:11 +0100)
----------------------------------------------------------------
Gerd Hoffmann (3):
xhci: create xhci_detach_slot helper function
xhci: call xhci_detach_slot on root port detach too
xhci: nuke transfe5rs on detach
Markus Armbruster (3):
ehci: Assert state machine is sane w.r.t. EHCIQueue
usb-host: Drop superfluous null test from usb_host_auto_scan()
usb-host: Initialize dev->port the obviously safe way
hw/usb/hcd-ehci.c | 4 ++++
hw/usb/hcd-xhci.c | 31 +++++++++++++++++++++++++------
hw/usb/host-linux.c | 4 ++--
3 files changed, 31 insertions(+), 8 deletions(-)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Qemu-devel] [PULL 0/6] usb patch queue
@ 2012-12-05 10:11 Gerd Hoffmann
2012-12-10 16:59 ` Anthony Liguori
0 siblings, 1 reply; 16+ messages in thread
From: Gerd Hoffmann @ 2012-12-05 10:11 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Hi,
Flushing the usb patch queue, there are a few bits sent during the
freeze I didn't feel like merging that close to the release, so
merge them now. Series reduces the ehci emulation cpu overhead and
allows to connect the usb tablet to ehci.
please pull,
Gerd
The following changes since commit 16c6c80ac3a772b42a87b77dfdf0fdac7c607b0e:
Open up 1.4 development branch (2012-12-03 14:08:40 -0600)
are available in the git repository at:
git://git.kraxel.org/qemu usb.74
Gerd Hoffmann (1):
add pc-1.4
Hans de Goede (5):
usb: Call wakeup when data becomes available for all devices with int eps
usb: Don't allow USB_RET_ASYNC for interrupt packets
usb: Allow overriding of usb_desc at the device level
ehci: Lower timer freq when the periodic schedule is idle
usb-tablet: Allow connecting to ehci
hw/pc_piix.c | 24 +++++++++++++-
hw/usb.h | 2 +
hw/usb/bus.c | 3 ++
hw/usb/core.c | 4 ++
hw/usb/dev-hid.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++++-
hw/usb/dev-hub.c | 2 +
hw/usb/dev-network.c | 7 ++++
hw/usb/dev-wacom.c | 4 ++
hw/usb/hcd-ehci.c | 39 +++++++++++++++++++---
hw/usb/hcd-ehci.h | 1 +
hw/usb/host-bsd.c | 1 +
hw/usb/host-linux.c | 1 +
hw/usb/redirect.c | 4 ++
13 files changed, 168 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [PULL 0/6] usb patch queue
2012-12-05 10:11 Gerd Hoffmann
@ 2012-12-10 16:59 ` Anthony Liguori
0 siblings, 0 replies; 16+ messages in thread
From: Anthony Liguori @ 2012-12-10 16:59 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
Gerd Hoffmann <kraxel@redhat.com> writes:
> Hi,
>
> Flushing the usb patch queue, there are a few bits sent during the
> freeze I didn't feel like merging that close to the release, so
> merge them now. Series reduces the ehci emulation cpu overhead and
> allows to connect the usb tablet to ehci.
>
> please pull,
Pulled. Thanks.
Regards,
Anthony Liguori
> Gerd
>
> The following changes since commit 16c6c80ac3a772b42a87b77dfdf0fdac7c607b0e:
>
> Open up 1.4 development branch (2012-12-03 14:08:40 -0600)
>
> are available in the git repository at:
> git://git.kraxel.org/qemu usb.74
>
> Gerd Hoffmann (1):
> add pc-1.4
>
> Hans de Goede (5):
> usb: Call wakeup when data becomes available for all devices with int eps
> usb: Don't allow USB_RET_ASYNC for interrupt packets
> usb: Allow overriding of usb_desc at the device level
> ehci: Lower timer freq when the periodic schedule is idle
> usb-tablet: Allow connecting to ehci
>
> hw/pc_piix.c | 24 +++++++++++++-
> hw/usb.h | 2 +
> hw/usb/bus.c | 3 ++
> hw/usb/core.c | 4 ++
> hw/usb/dev-hid.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++++-
> hw/usb/dev-hub.c | 2 +
> hw/usb/dev-network.c | 7 ++++
> hw/usb/dev-wacom.c | 4 ++
> hw/usb/hcd-ehci.c | 39 +++++++++++++++++++---
> hw/usb/hcd-ehci.h | 1 +
> hw/usb/host-bsd.c | 1 +
> hw/usb/host-linux.c | 1 +
> hw/usb/redirect.c | 4 ++
> 13 files changed, 168 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Qemu-devel] [PULL 0/6] usb patch queue
@ 2012-07-12 13:08 Gerd Hoffmann
0 siblings, 0 replies; 16+ messages in thread
From: Gerd Hoffmann @ 2012-07-12 13:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Hi,
Brings UAS (usb attached scsi) support, fixes and improvements for the
ehci interrupt handling and a little uhci loadvm compatibility bugfix.
please pull,
Gerd
The following changes since commit 92336855975805d88c7979f53bc05c2d47abab04:
megasas: disable due to build breakage (2012-07-09 18:16:16 -0500)
are available in the git repository at:
git://git.kraxel.org/qemu usb.57
Gerd Hoffmann (5):
usb: add usb attached scsi emulation
uhci: initialize expire_time when loading v1 vmstate
ehci: raise irq in the frame timer
ehci: implement Interrupt Threshold Control support
ehci: improve expire time calculation
Paolo Bonzini (1):
scsi: add free_request callback
docs/usb-storage.txt | 38 +++
hw/scsi-bus.c | 5 +
hw/scsi.h | 1 +
hw/usb/Makefile.objs | 1 +
hw/usb/dev-uas.c | 779 ++++++++++++++++++++++++++++++++++++++++++++++++++
hw/usb/hcd-ehci.c | 91 ++++---
hw/usb/hcd-uhci.c | 12 +
trace-events | 16 +-
8 files changed, 909 insertions(+), 34 deletions(-)
create mode 100644 docs/usb-storage.txt
create mode 100644 hw/usb/dev-uas.c
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Qemu-devel] [PULL 0/6] usb patch queue.
@ 2012-06-20 14:05 Gerd Hoffmann
0 siblings, 0 replies; 16+ messages in thread
From: Gerd Hoffmann @ 2012-06-20 14:05 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Hi,
This is the usb patch queue, featuring live migration support for
ehci and usb-host. Also as usual some small bugfixes.
pleae pull,
Gerd
The following changes since commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4:
Allow machines to configure the QEMU_VERSION that's exposed via hardware (2012-06-19 13:36:56 -0500)
are available in the git repository at:
git://git.kraxel.org/qemu usb.54
Gerd Hoffmann (6):
ehci: add live migration support
usb: restore USBDevice->attached on vmload
ehci: tracing improvements
usb-host: attach only to running guest
usb-host: live migration support
uhci: fix uhci_async_cancel_all
hw/usb/bus.c | 13 ++++++++
hw/usb/hcd-ehci.c | 69 +++++++++++++++++++++++++++++++++++++++-----
hw/usb/hcd-uhci.c | 4 +-
hw/usb/host-linux.c | 79 ++++++++++++++++++++++++++++++++++++++++----------
trace-events | 5 ++-
5 files changed, 142 insertions(+), 28 deletions(-)
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2017-05-15 13:30 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-21 11:10 [Qemu-devel] [PULL 0/6] usb patch queue Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 1/6] usb: Fix compilation for Windows Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 2/6] usb: fix unbounded stack warning for xhci_dma_write_u32s Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 3/6] usb: fix unbound stack usage for usb_mtp_add_str Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 4/6] usb: fix unbound stack warning for inotify_watchfn Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 5/6] hw/usb/dev-mtp: Guard inotify usage with CONFIG_INOTIFY1 Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 6/6] usb: ehci: add capability mmio write function Gerd Hoffmann
2016-03-22 17:39 ` [Qemu-devel] [PULL 0/6] usb patch queue Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2017-05-12 12:21 Gerd Hoffmann
2017-05-15 13:30 ` Stefan Hajnoczi
2013-01-14 11:50 Gerd Hoffmann
2013-01-14 18:03 ` Anthony Liguori
2012-12-05 10:11 Gerd Hoffmann
2012-12-10 16:59 ` Anthony Liguori
2012-07-12 13:08 Gerd Hoffmann
2012-06-20 14:05 Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).