qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Peter Xu <peterx@redhat.com>
Subject: [Qemu-devel] [PULL 4/6] usb: fix unbound stack warning for inotify_watchfn
Date: Mon, 21 Mar 2016 12:10:22 +0100	[thread overview]
Message-ID: <1458558624-6890-5-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1458558624-6890-1-git-send-email-kraxel@redhat.com>

From: Peter Xu <peterx@redhat.com>

Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1457503640-31473-1-git-send-email-peterx@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/dev-mtp.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 62fb7cd..01c5e51 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -433,12 +433,11 @@ static void inotify_watchfn(void *arg)
     MTPState *s = arg;
     ssize_t bytes;
     /* From the man page: atleast one event can be read */
-    int len = sizeof(struct inotify_event) + NAME_MAX + 1;
     int pos;
-    char buf[len];
+    char buf[sizeof(struct inotify_event) + NAME_MAX + 1];
 
     for (;;) {
-        bytes = read(s->inotifyfd, buf, len);
+        bytes = read(s->inotifyfd, buf, sizeof(buf));
         pos = 0;
 
         if (bytes <= 0) {
-- 
1.8.3.1

  parent reply	other threads:[~2016-03-21 11:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 11:10 [Qemu-devel] [PULL 0/6] usb patch queue Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 1/6] usb: Fix compilation for Windows Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 2/6] usb: fix unbounded stack warning for xhci_dma_write_u32s Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 3/6] usb: fix unbound stack usage for usb_mtp_add_str Gerd Hoffmann
2016-03-21 11:10 ` Gerd Hoffmann [this message]
2016-03-21 11:10 ` [Qemu-devel] [PULL 5/6] hw/usb/dev-mtp: Guard inotify usage with CONFIG_INOTIFY1 Gerd Hoffmann
2016-03-21 11:10 ` [Qemu-devel] [PULL 6/6] usb: ehci: add capability mmio write function Gerd Hoffmann
2016-03-22 17:39 ` [Qemu-devel] [PULL 0/6] usb patch queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458558624-6890-5-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).