From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai3do-0001i8-WF for qemu-devel@nongnu.org; Mon, 21 Mar 2016 13:29:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai3dl-0000vw-MG for qemu-devel@nongnu.org; Mon, 21 Mar 2016 13:29:20 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:49805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai3dl-0000vg-EK for qemu-devel@nongnu.org; Mon, 21 Mar 2016 13:29:17 -0400 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 21 Mar 2016 11:29:14 -0600 From: Michael Roth Date: Mon, 21 Mar 2016 12:28:12 -0500 Message-Id: <1458581313-19045-15-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1458581313-19045-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1458581313-19045-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 14/35] net/dump: fix nfds->filename leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jason Wang , qemu-stable@nongnu.org, Li Zhijian , Michael Roth From: Li Zhijian Cc: Jason Wang Signed-off-by: Li Zhijian Cc: qemu-stable@nongnu.org Signed-off-by: Jason Wang (cherry picked from commit b50c7d452f5aef52cc9e7461f215cab87c3f3b03) Signed-off-by: Michael Roth --- net/dump.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/dump.c b/net/dump.c index ce16a4b..347b5ca 100644 --- a/net/dump.c +++ b/net/dump.c @@ -329,6 +329,13 @@ static void filter_dump_instance_init(Object *obj) file_dump_set_filename, NULL); } +static void filter_dump_instance_finalize(Object *obj) +{ + NetFilterDumpState *nfds = FILTER_DUMP(obj); + + g_free(nfds->filename); +} + static void filter_dump_class_init(ObjectClass *oc, void *data) { NetFilterClass *nfc = NETFILTER_CLASS(oc); @@ -343,6 +350,7 @@ static const TypeInfo filter_dump_info = { .parent = TYPE_NETFILTER, .class_init = filter_dump_class_init, .instance_init = filter_dump_instance_init, + .instance_finalize = filter_dump_instance_finalize, .instance_size = sizeof(NetFilterDumpState), }; -- 1.9.1