From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai3mJ-0000XK-Gn for qemu-devel@nongnu.org; Mon, 21 Mar 2016 13:38:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai3mF-0003xk-NV for qemu-devel@nongnu.org; Mon, 21 Mar 2016 13:38:07 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:43030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai3mF-0003xg-5u for qemu-devel@nongnu.org; Mon, 21 Mar 2016 13:38:03 -0400 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 21 Mar 2016 11:38:02 -0600 Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 913A31FF0059 for ; Mon, 21 Mar 2016 11:26:08 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2LHbxKW34472096 for ; Mon, 21 Mar 2016 10:37:59 -0700 Received: from d03av01.boulder.ibm.com (localhost [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2LHbwQM025466 for ; Mon, 21 Mar 2016 11:37:59 -0600 From: Michael Roth Date: Mon, 21 Mar 2016 12:37:46 -0500 Message-Id: <1458581866-21907-2-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1458581866-21907-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1458581866-21907-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PULL 1/1] qemu-ga: drop unused local err variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Michael Roth , Stefan Hajnoczi From: Stefan Hajnoczi Commit 125b310e1d62e3a1dc1e7758563e598957ca7ae4 ("qemu-ga: move channel/transport functionality into wrapper class") stopped using the local err variable in channel_event_cb(). This patch deletes the unused variable. Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Michael Roth --- qga/main.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/qga/main.c b/qga/main.c index 0a168e2..743c5c1 100644 --- a/qga/main.c +++ b/qga/main.c @@ -618,13 +618,7 @@ static gboolean channel_event_cb(GIOCondition condition, gpointer data) GAState *s = data; gchar buf[QGA_READ_COUNT_DEFAULT+1]; gsize count; - GError *err = NULL; GIOStatus status = ga_channel_read(s->channel, buf, QGA_READ_COUNT_DEFAULT, &count); - if (err != NULL) { - g_warning("error reading channel: %s", err->message); - g_error_free(err); - return false; - } switch (status) { case G_IO_STATUS_ERROR: g_warning("error reading channel"); -- 1.9.1