qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL v2 38/40] ivshmem: Drop ivshmem property x-memdev
Date: Mon, 21 Mar 2016 21:44:01 +0100	[thread overview]
Message-ID: <1458593043-31731-39-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1458593043-31731-1-git-send-email-armbru@redhat.com>

Use ivshmem-plain instead.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1458066895-20632-39-git-send-email-armbru@redhat.com>
---
 hw/misc/ivshmem.c | 23 +++--------------------
 1 file changed, 3 insertions(+), 20 deletions(-)

diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 527d636..4552060 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -1210,17 +1210,12 @@ static void ivshmem_realize(PCIDevice *dev, Error **errp)
                      " or ivshmem-doorbell instead");
     }
 
-    if (!!s->server_chr + !!s->shmobj + !!s->hostmem != 1) {
-        error_setg(errp,
-                   "You must specify either 'shm', 'chardev' or 'x-memdev'");
+    if (!!s->server_chr + !!s->shmobj != 1) {
+        error_setg(errp, "You must specify either 'shm' or 'chardev'");
         return;
     }
 
-    if (s->hostmem) {
-        if (s->sizearg) {
-            g_warning("size argument ignored with hostmem");
-        }
-    } else if (s->sizearg == NULL) {
+    if (s->sizearg == NULL) {
         s->legacy_size = 4 << 20; /* 4 MB default */
     } else {
         char *end;
@@ -1260,17 +1255,6 @@ static void ivshmem_realize(PCIDevice *dev, Error **errp)
     ivshmem_common_realize(dev, errp);
 }
 
-static void ivshmem_init(Object *obj)
-{
-    IVShmemState *s = IVSHMEM(obj);
-
-    object_property_add_link(obj, "x-memdev", TYPE_MEMORY_BACKEND,
-                             (Object **)&s->hostmem,
-                             ivshmem_check_memdev_is_busy,
-                             OBJ_PROP_LINK_UNREF_ON_RELEASE,
-                             &error_abort);
-}
-
 static void ivshmem_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
@@ -1287,7 +1271,6 @@ static const TypeInfo ivshmem_info = {
     .name          = TYPE_IVSHMEM,
     .parent        = TYPE_IVSHMEM_COMMON,
     .instance_size = sizeof(IVShmemState),
-    .instance_init = ivshmem_init,
     .class_init    = ivshmem_class_init,
 };
 
-- 
2.4.3

  parent reply	other threads:[~2016-03-21 20:44 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 20:43 [Qemu-devel] [PULL v2 00/40] ivshmem: Fixes, cleanups, device model split Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 01/40] target-ppc: Document TOCTTOU in hugepage support Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 02/40] ivshmem-server: Fix and clean up command line help Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 03/40] ivshmem-server: Don't overload POSIX shmem and file name Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 04/40] qemu-doc: Fix ivshmem huge page example Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 05/40] event_notifier: Make event_notifier_init_fd() #ifdef CONFIG_EVENTFD Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 06/40] tests/libqos/pci-pc: Fix qpci_pc_iomap() to map BARs aligned Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 07/40] ivshmem-test: Improve test case /ivshmem/single Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 08/40] ivshmem-test: Clean up wait for devices to become operational Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 09/40] ivshmem-test: Improve test cases /ivshmem/server-* Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 10/40] ivshmem: Rewrite specification document Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 11/40] ivshmem: Add missing newlines to debug printfs Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 12/40] ivshmem: Compile debug prints unconditionally to prevent bit-rot Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 13/40] ivshmem: Clean up after commit 9940c32 Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 14/40] ivshmem: Drop ivshmem_event() stub Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 15/40] ivshmem: Don't destroy the chardev on version mismatch Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 16/40] ivshmem: Fix harmless misuse of Error Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 17/40] ivshmem: Failed realize() can leave migration blocker behind Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 18/40] ivshmem: Clean up register callbacks Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 19/40] ivshmem: Clean up MSI-X conditions Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 20/40] ivshmem: Leave INTx alone when using MSI-X Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 21/40] ivshmem: Assert interrupts are set up once Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 22/40] ivshmem: Simplify rejection of invalid peer ID from server Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 23/40] ivshmem: Disentangle ivshmem_read() Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 24/40] ivshmem: Plug leaks on unplug, fix peer disconnect Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 25/40] ivshmem: Receive shared memory synchronously in realize() Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 26/40] ivshmem: Propagate errors through ivshmem_recv_setup() Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 27/40] ivshmem: Rely on server sending the ID right after the version Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 28/40] ivshmem: Drop the hackish test for UNIX domain chardev Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 29/40] ivshmem: Simplify how we cope with short reads from server Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 30/40] ivshmem: Tighten check of property "size" Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 31/40] ivshmem: Implement shm=... with a memory backend Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 32/40] ivshmem: Simplify memory regions for BAR 2 (shared memory) Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 33/40] ivshmem: Inline check_shm_size() into its only caller Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 34/40] qdev: New DEFINE_PROP_ON_OFF_AUTO Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 35/40] ivshmem: Replace int role_val by OnOffAuto master Markus Armbruster
2016-03-21 20:43 ` [Qemu-devel] [PULL v2 36/40] ivshmem: Split ivshmem-plain, ivshmem-doorbell off ivshmem Markus Armbruster
2016-03-21 20:44 ` [Qemu-devel] [PULL v2 37/40] ivshmem: Clean up after the previous commit Markus Armbruster
2016-03-21 20:44 ` Markus Armbruster [this message]
2016-03-21 20:44 ` [Qemu-devel] [PULL v2 39/40] ivshmem: Require master to have ID zero Markus Armbruster
2016-03-21 20:44 ` [Qemu-devel] [PULL v2 40/40] contrib/ivshmem-server: Print "not for production" warning Markus Armbruster
2016-03-22 16:40 ` [Qemu-devel] [PULL v2 00/40] ivshmem: Fixes, cleanups, device model split Peter Maydell
2016-03-22 18:02   ` Markus Armbruster
2016-03-23 14:15     ` Peter Maydell
2016-04-08 20:13       ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458593043-31731-39-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).