qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 01/10] target-tricore: add missing break in insn decode switch stmt
Date: Tue, 22 Mar 2016 14:46:17 +0100	[thread overview]
Message-ID: <1458654386-1001-2-git-send-email-kbastian@mail.uni-paderborn.de> (raw)
In-Reply-To: <1458654386-1001-1-git-send-email-kbastian@mail.uni-paderborn.de>

After decoding/translating a RRR_DIVIDE/RRRR_EXTRACT_INSERT type instruction
we would simply fall through and would decode/translate another unintended
RRR2_MADD/RRRW_EXTRACT_INSERT instruction.

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-Id: <1458547383-23102-2-git-send-email-kbastian@mail.uni-paderborn.de>
---
 target-tricore/translate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target-tricore/translate.c b/target-tricore/translate.c
index d13e5c8..66f798a 100644
--- a/target-tricore/translate.c
+++ b/target-tricore/translate.c
@@ -8632,6 +8632,7 @@ static void decode_32Bit_opc(CPUTriCoreState *env, DisasContext *ctx)
         break;
     case OPCM_32_RRR_DIVIDE:
         decode_rrr_divide(env, ctx);
+        break;
 /* RRR2 Format */
     case OPCM_32_RRR2_MADD:
         decode_rrr2_madd(env, ctx);
@@ -8661,6 +8662,7 @@ static void decode_32Bit_opc(CPUTriCoreState *env, DisasContext *ctx)
 /* RRRR format */
     case OPCM_32_RRRR_EXTRACT_INSERT:
         decode_rrrr_extract_insert(env, ctx);
+        break;
 /* RRRW format */
     case OPCM_32_RRRW_EXTRACT_INSERT:
         decode_rrrw_extract_insert(env, ctx);
-- 
2.7.4

  reply	other threads:[~2016-03-22 13:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 13:46 [Qemu-devel] [PULL 00/10] tricore-patches Bastian Koppelmann
2016-03-22 13:46 ` Bastian Koppelmann [this message]
2016-03-22 13:46 ` [Qemu-devel] [PULL 02/10] target-tricore: Fix helper_msub64_q_ssov not reseting OVF bit Bastian Koppelmann
2016-03-22 13:46 ` [Qemu-devel] [PULL 03/10] target-tricore: Fix psw_read() clearing too many bits Bastian Koppelmann
2016-03-22 13:46 ` [Qemu-devel] [PULL 04/10] target-tricore: Add FPU infrastructure Bastian Koppelmann
2016-03-22 13:46 ` [Qemu-devel] [PULL 05/10] target-tricore: Move general CHECK_REG_PAIR of decode_rrr_divide Bastian Koppelmann
2016-03-22 13:46 ` [Qemu-devel] [PULL 06/10] target-tricore: add add.f/sub.f instructions Bastian Koppelmann
2016-03-22 13:46 ` [Qemu-devel] [PULL 07/10] target-tricore: Add mul.f instruction Bastian Koppelmann
2016-03-22 13:46 ` [Qemu-devel] [PULL 08/10] target-tricore: Add div.f instruction Bastian Koppelmann
2016-03-22 13:46 ` [Qemu-devel] [PULL 09/10] target-tricore: Add cmp.f instruction Bastian Koppelmann
2016-03-22 13:46 ` [Qemu-devel] [PULL 10/10] target-tricore: Add ftoi and itof instructions Bastian Koppelmann
2016-03-22 20:15 ` [Qemu-devel] [PULL 00/10] tricore-patches Peter Maydell
2016-03-23  8:17   ` Bastian Koppelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458654386-1001-2-git-send-email-kbastian@mail.uni-paderborn.de \
    --to=kbastian@mail.uni-paderborn.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).