From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiMeQ-0007n9-Kf for qemu-devel@nongnu.org; Tue, 22 Mar 2016 09:47:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiMeM-0005L6-6P for qemu-devel@nongnu.org; Tue, 22 Mar 2016 09:47:14 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:51769) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiMeM-0005JM-0V for qemu-devel@nongnu.org; Tue, 22 Mar 2016 09:47:10 -0400 From: Bastian Koppelmann Date: Tue, 22 Mar 2016 14:46:17 +0100 Message-Id: <1458654386-1001-2-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1458654386-1001-1-git-send-email-kbastian@mail.uni-paderborn.de> References: <1458654386-1001-1-git-send-email-kbastian@mail.uni-paderborn.de> Subject: [Qemu-devel] [PULL 01/10] target-tricore: add missing break in insn decode switch stmt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org After decoding/translating a RRR_DIVIDE/RRRR_EXTRACT_INSERT type instruction we would simply fall through and would decode/translate another unintended RRR2_MADD/RRRW_EXTRACT_INSERT instruction. Signed-off-by: Bastian Koppelmann Message-Id: <1458547383-23102-2-git-send-email-kbastian@mail.uni-paderborn.de> --- target-tricore/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index d13e5c8..66f798a 100644 --- a/target-tricore/translate.c +++ b/target-tricore/translate.c @@ -8632,6 +8632,7 @@ static void decode_32Bit_opc(CPUTriCoreState *env, DisasContext *ctx) break; case OPCM_32_RRR_DIVIDE: decode_rrr_divide(env, ctx); + break; /* RRR2 Format */ case OPCM_32_RRR2_MADD: decode_rrr2_madd(env, ctx); @@ -8661,6 +8662,7 @@ static void decode_32Bit_opc(CPUTriCoreState *env, DisasContext *ctx) /* RRRR format */ case OPCM_32_RRRR_EXTRACT_INSERT: decode_rrrr_extract_insert(env, ctx); + break; /* RRRW format */ case OPCM_32_RRRW_EXTRACT_INSERT: decode_rrrw_extract_insert(env, ctx); -- 2.7.4