From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aitJy-0008MM-J0 for qemu-devel@nongnu.org; Wed, 23 Mar 2016 20:40:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aitJu-0003XI-4U for qemu-devel@nongnu.org; Wed, 23 Mar 2016 20:40:18 -0400 Received: from [59.151.112.132] (port=46673 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aitJt-0003WK-8E for qemu-devel@nongnu.org; Wed, 23 Mar 2016 20:40:14 -0400 From: "Wei, Jiangang" Date: Thu, 24 Mar 2016 00:40:00 +0000 Message-ID: <1458779994.2191.2.camel@localhost> References: <1458727724-5538-1-git-send-email-weijg.fnst@cn.fujitsu.com> <1458727724-5538-3-git-send-email-weijg.fnst@cn.fujitsu.com> <87d1ql8km4.fsf@blackfin.pond.sub.org> In-Reply-To: <87d1ql8km4.fsf@blackfin.pond.sub.org> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <111B9179173358488AEA9F4B2EBCE357@fujitsu.local> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 2/2] hw/pci-bridge: Convert pxb initialization functions to Error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "armbru@redhat.com" Cc: "marcel@redhat.com" , "Cao, Jin" , "qemu-devel@nongnu.org" , "mst@redhat.com" T24gV2VkLCAyMDE2LTAzLTIzIGF0IDEzOjA1ICswMTAwLCBNYXJrdXMgQXJt YnJ1c3RlciB3cm90ZToNCj4gV2VpIEppYW5nYW5nIDx3ZWlqZy5mbnN0QGNu LmZ1aml0c3UuY29tPiB3cml0ZXM6DQo+IA0KPiA+IEZpcnN0bHksIGNvbnZl cnQgcHhiX2Rldl9pbml0X2NvbW1vbigpIHRvIEVycm9yIGFuZCByZW5hbWUN Cj4gPiBpdCB0byBweGJfZGV2X3JlYWxpemVfY29tbW9uKCkuDQo+ID4gQWN0 dWFsbHksIHB4Yl9yZWdpc3Rlcl9idXMoKSBpcyBjb252ZXJ0ZWQgYXMgd2Vs bC4NCj4gPg0KPiA+IEFuZCB0aGVuLA0KPiA+IGNvbnZlcnQgcHhiX2Rldl9p bml0Zm4oKSBhbmQgcHhiX3BjaWVfZGV2X2luaXRmbigpIHRvIEVycm9yLA0K PiA+IHJlbmFtZSB0aGVtIHRvIHB4Yl9kZXZfcmVhbGl6ZSgpIGFuZCBweGJf cGNpZV9kZXZfcmVhbGl6ZSgpDQo+ID4gcmVzcGVjdGl2ZWx5Lg0KPiA+IC0t LQ0KPiA+ICBody9wY2ktYnJpZGdlL3BjaV9leHBhbmRlcl9icmlkZ2UuYyB8 IDU0ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0NCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDI3IGRlbGV0 aW9ucygtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL2h3L3BjaS1icmlkZ2Uv cGNpX2V4cGFuZGVyX2JyaWRnZS5jIGIvaHcvcGNpLWJyaWRnZS9wY2lfZXhw YW5kZXJfYnJpZGdlLmMNCj4gPiBpbmRleCBiYTMyMGJkLi42ZjUzYTZiIDEw MDY0NA0KPiA+IC0tLSBhL2h3L3BjaS1icmlkZ2UvcGNpX2V4cGFuZGVyX2Jy aWRnZS5jDQo+ID4gKysrIGIvaHcvcGNpLWJyaWRnZS9wY2lfZXhwYW5kZXJf YnJpZGdlLmMNCj4gPiBAQCAtMTYwLDMwICsxNjAsMjUgQEAgc3RhdGljIGNv bnN0IFR5cGVJbmZvIHB4Yl9ob3N0X2luZm8gPSB7DQo+ID4gIH07DQo+ID4g IA0KPiA+ICAvKg0KPiA+IC0gKiBSZWdpc3RlcnMgdGhlIFBYQiBidXMgYXMg YSBjaGlsZCBvZiB0aGUgaTQ0MGZ4IHJvb3QgYnVzLg0KPiA+IC0gKg0KPiA+ IC0gKiBSZXR1cm5zIDAgb24gc3VjY2Vzc3MsIC0xIGlmIGk0NDBmeCBob3N0 IHdhcyBub3QNCj4gPiAtICogZm91bmQgb3IgdGhlIGJ1cyBudW1iZXIgaXMg YWxyZWFkeSBpbiB1c2UuDQo+ID4gKyAqIFJlZ2lzdGVycyB0aGUgUFhCIGJ1 cyBhcyBhIGNoaWxkIG9mIHBjaSBob3N0IHJvb3QgYnVzLg0KPiA+ICAgKi8N Cj4gPiAtc3RhdGljIGludCBweGJfcmVnaXN0ZXJfYnVzKFBDSURldmljZSAq ZGV2LCBQQ0lCdXMgKnB4Yl9idXMpDQo+ID4gK3N0YXRpYyB2b2lkIHB4Yl9y ZWdpc3Rlcl9idXMoUENJRGV2aWNlICpkZXYsIFBDSUJ1cyAqcHhiX2J1cywg RXJyb3IgKiplcnJwKQ0KPiA+ICB7DQo+ID4gICAgICBQQ0lCdXMgKmJ1cyA9 IGRldi0+YnVzOw0KPiA+ICAgICAgaW50IHB4Yl9idXNfbnVtID0gcGNpX2J1 c19udW0ocHhiX2J1cyk7DQo+ID4gIA0KPiA+ICAgICAgaWYgKGJ1cy0+cGFy ZW50X2Rldikgew0KPiA+IC0gICAgICAgIGVycm9yX3JlcG9ydCgiUFhCIGRl dmljZXMgY2FuIGJlIGF0dGFjaGVkIG9ubHkgdG8gcm9vdCBidXMuIik7DQo+ ID4gLSAgICAgICAgcmV0dXJuIC0xOw0KPiA+ICsgICAgICAgIGVycm9yX3Nl dGcoZXJycCwgIlBYQiBkZXZpY2VzIGNhbiBiZSBhdHRhY2hlZCBvbmx5IHRv IHJvb3QgYnVzIik7DQo+ID4gKyAgICAgICAgcmV0dXJuOw0KPiA+ICAgICAg fQ0KPiA+ICANCj4gPiAgICAgIFFMSVNUX0ZPUkVBQ0goYnVzLCAmYnVzLT5j aGlsZCwgc2libGluZykgew0KPiA+ICAgICAgICAgIGlmIChwY2lfYnVzX251 bShidXMpID09IHB4Yl9idXNfbnVtKSB7DQo+ID4gLSAgICAgICAgICAgIGVy cm9yX3JlcG9ydCgiQnVzICVkIGlzIGFscmVhZHkgaW4gdXNlLiIsIHB4Yl9i dXNfbnVtKTsNCj4gPiAtICAgICAgICAgICAgcmV0dXJuIC0xOw0KPiA+ICsg ICAgICAgICAgICBlcnJvcl9zZXRnKGVycnAsICJCdXMgJWQgaXMgYWxyZWFk eSBpbiB1c2UiLCBweGJfYnVzX251bSk7DQo+ID4gKyAgICAgICAgICAgIHJl dHVybjsNCj4gPiAgICAgICAgICB9DQo+ID4gICAgICB9DQo+ID4gICAgICBR TElTVF9JTlNFUlRfSEVBRCgmZGV2LT5idXMtPmNoaWxkLCBweGJfYnVzLCBz aWJsaW5nKTsNCj4gPiAtDQo+ID4gLSAgICByZXR1cm4gMDsNCj4gPiAgfQ0K PiA+ICANCj4gPiAgc3RhdGljIGludCBweGJfbWFwX2lycV9mbihQQ0lEZXZp Y2UgKnBjaV9kZXYsIGludCBwaW4pDQo+ID4gQEAgLTIxMywxNyArMjA4LDIx IEBAIHN0YXRpYyBnaW50IHB4Yl9jb21wYXJlKGdjb25zdHBvaW50ZXIgYSwg Z2NvbnN0cG9pbnRlciBiKQ0KPiA+ICAgICAgICAgICAgIDA7DQo+ID4gIH0N Cj4gPiAgDQo+ID4gLXN0YXRpYyBpbnQgcHhiX2Rldl9pbml0X2NvbW1vbihQ Q0lEZXZpY2UgKmRldiwgYm9vbCBwY2llKQ0KPiA+ICtzdGF0aWMgdm9pZCBw eGJfZGV2X3JlYWxpemVfY29tbW9uKFBDSURldmljZSAqZGV2LCBib29sIHBj aWUsIEVycm9yICoqZXJycCkNCj4gPiAgew0KPiA+ICAgICAgUFhCRGV2ICpw eGIgPSBjb252ZXJ0X3RvX3B4YihkZXYpOw0KPiA+ICAgICAgRGV2aWNlU3Rh dGUgKmRzLCAqYmRzID0gTlVMTDsNCj4gPiAgICAgIFBDSUJ1cyAqYnVzOw0K PiA+ICAgICAgY29uc3QgY2hhciAqZGV2X25hbWUgPSBOVUxMOw0KPiA+ICsg ICAgRXJyb3IgKmVyciA9IE5VTEw7DQo+ID4gIA0KPiA+ICAgICAgaWYgKHB4 Yi0+bnVtYV9ub2RlICE9IE5VTUFfTk9ERV9VTkFTU0lHTkVEICYmDQo+ID4g ICAgICAgICAgcHhiLT5udW1hX25vZGUgPj0gbmJfbnVtYV9ub2Rlcykgew0K PiA+IC0gICAgICAgIGVycm9yX3JlcG9ydCgiSWxsZWdhbCBudW1hIG5vZGUg JWQuIiwgcHhiLT5udW1hX25vZGUpOw0KPiA+IC0gICAgICAgIHJldHVybiAt RUlOVkFMOw0KPiA+ICsgICAgICAgIGVycm9yX3NldGcoJmVyciwgIklsbGVn YWwgbnVtYSBub2RlICVkIiwgcHhiLT5udW1hX25vZGUpOw0KPiA+ICsgICAg ICAgIGlmIChlcnIpIHsNCj4gPiArICAgICAgICAgICAgZXJyb3JfcHJvcGFn YXRlKGVycnAsIGVycik7DQo+ID4gKyAgICAgICAgfQ0KPiANCj4gTm8uICB2 MiBnb3QgaXQgcmlnaHQuDQpUaGFua3MgZm9yIHlvdXIgcmVzcG9uc2UuDQpP SywgTGV0IHVzIGRpc2NhcmQgdjMuDQoNCj4gDQo+ID4gKyAgICAgICAgcmV0 dXJuOw0KPiA+ICAgICAgfQ0KPiA+ICANCj4gPiAgICAgIGlmIChkZXYtPnFk ZXYuaWQgJiYgKmRldi0+cWRldi5pZCkgew0KPiBbLi4uXQ0KPiANCj4gDQoN CgoK