From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj084-0005hF-Up for qemu-devel@nongnu.org; Thu, 24 Mar 2016 03:56:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj081-0002cw-Gr for qemu-devel@nongnu.org; Thu, 24 Mar 2016 03:56:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj081-0002ar-BX for qemu-devel@nongnu.org; Thu, 24 Mar 2016 03:56:25 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 4F43D63146 for ; Thu, 24 Mar 2016 07:56:23 +0000 (UTC) From: Gerd Hoffmann Date: Thu, 24 Mar 2016 08:56:18 +0100 Message-Id: <1458806178-31096-4-git-send-email-kraxel@redhat.com> In-Reply-To: <1458806178-31096-1-git-send-email-kraxel@redhat.com> References: <1458806178-31096-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 3/3] spice: Disallow use of gl + TCP port List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Christophe Fergeau From: Christophe Fergeau Currently, virgl support has to go through a local unix socket, trying to connect to a VM using -spice gl through spice://localhost:5900 will only result in a black screen. This commit errors out when the user tries to start a VM with both GL support and a port/tls-port set. This would fit better in spice-server, but currently QEMU does not call into spice-server when parsing 'gl' on its command line, so we have to do this check in QEMU instead. Signed-off-by: Christophe Fergeau Reviewed-by: Marc-Andr=C3=A9 Lureau Message-id: 1457955672-28758-1-git-send-email-cfergeau@redhat.com [ applied codestyle fix: break long line ] Signed-off-by: Gerd Hoffmann --- ui/spice-core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ui/spice-core.c b/ui/spice-core.c index e117925..61db3c1 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -828,6 +828,11 @@ void qemu_spice_init(void) =20 #ifdef HAVE_SPICE_GL if (qemu_opt_get_bool(opts, "gl", 0)) { + if ((port !=3D 0) || (tls_port !=3D 0)) { + error_report("SPICE GL support is local-only for now and " + "incompatible with -spice port/tls-port"); + exit(1); + } if (egl_rendernode_init() =3D=3D 0) { display_opengl =3D 1; } --=20 1.8.3.1