From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj8II-0000xv-2g for qemu-devel@nongnu.org; Thu, 24 Mar 2016 12:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj8IG-0001WL-TO for qemu-devel@nongnu.org; Thu, 24 Mar 2016 12:39:33 -0400 Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 24 Mar 2016 17:39:21 +0100 Message-Id: <1458837566-108527-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1458837566-108527-1-git-send-email-pbonzini@redhat.com> References: <1458837566-108527-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 2/7] block: make bdrv_start_throttled_reqs return void List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org The return value is unused and I am not sure why it would be useful. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- block/io.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/block/io.c b/block/io.c index cbba269..3703426 100644 --- a/block/io.c +++ b/block/io.c @@ -69,10 +69,8 @@ void bdrv_set_io_limits(BlockDriverState *bs, } } -/* this function drain all the throttled IOs */ -static bool bdrv_start_throttled_reqs(BlockDriverState *bs) +static void bdrv_start_throttled_reqs(BlockDriverState *bs) { - bool drained = false; bool enabled = bs->io_limits_enabled; int i; @@ -80,13 +78,11 @@ static bool bdrv_start_throttled_reqs(BlockDriverState *bs) for (i = 0; i < 2; i++) { while (qemu_co_enter_next(&bs->throttled_reqs[i])) { - drained = true; + ; } } bs->io_limits_enabled = enabled; - - return drained; } void bdrv_io_limits_disable(BlockDriverState *bs) -- 1.8.3.1