From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akWNB-0006OO-57 for qemu-devel@nongnu.org; Mon, 28 Mar 2016 08:34:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akWN7-0003ru-T0 for qemu-devel@nongnu.org; Mon, 28 Mar 2016 08:34:21 -0400 Received: from mail-pa0-x241.google.com ([2607:f8b0:400e:c03::241]:36157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akWN7-0003rn-L9 for qemu-devel@nongnu.org; Mon, 28 Mar 2016 08:34:17 -0400 Received: by mail-pa0-x241.google.com with SMTP id 1so14971460pal.3 for ; Mon, 28 Mar 2016 05:34:17 -0700 (PDT) Received: from Inspiron-N5010.domain.name ([183.87.60.98]) by smtp.gmail.com with ESMTPSA id n74sm35558918pfa.45.2016.03.28.05.34.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 28 Mar 2016 05:34:15 -0700 (PDT) From: Pooja Dhannawat Date: Mon, 28 Mar 2016 18:04:11 +0530 Message-Id: <1459168451-2626-1-git-send-email-dhannawatpooja1@gmail.com> Subject: [Qemu-devel] [PATCH v5] net: Allocating Large sized arrays to heap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org nc_sendv_compat has a huge stack usage of 69680 bytes approx. Moving large arrays to heap to reduce stack usage. Reviewed-by: Stefan Hajnoczi Signed-off-by: Pooja Dhannawat --- net/net.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/net/net.c b/net/net.c index b0c832e..663da13 100644 --- a/net/net.c +++ b/net/net.c @@ -709,23 +709,28 @@ ssize_t qemu_send_packet_raw(NetClientState *nc, const uint8_t *buf, int size) static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, int iovcnt, unsigned flags) { - uint8_t buf[NET_BUFSIZE]; + uint8_t *buf = NULL; uint8_t *buffer; size_t offset; + ssize_t ret; if (iovcnt == 1) { buffer = iov[0].iov_base; offset = iov[0].iov_len; } else { + buf = g_new(uint8_t, NET_BUFSIZE); buffer = buf; - offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); + offset = iov_to_buf(iov, iovcnt, 0, buf, NET_BUFSIZE); } if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { - return nc->info->receive_raw(nc, buffer, offset); + ret = nc->info->receive_raw(nc, buffer, offset); } else { - return nc->info->receive(nc, buffer, offset); + ret = nc->info->receive(nc, buffer, offset); } + + g_free(buf); + return ret; } ssize_t qemu_deliver_packet_iov(NetClientState *sender, -- 2.5.0