From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v2 16/20] block: Use bdrv_parse_cache_mode() in drive_init()
Date: Tue, 29 Mar 2016 15:30:53 +0200 [thread overview]
Message-ID: <1459258257-17767-17-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1459258257-17767-1-git-send-email-kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
blockdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 27c9b59..c2dd584 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -897,8 +897,9 @@ DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_default_type)
value = qemu_opt_get(all_opts, "cache");
if (value) {
int flags = 0;
+ bool writethrough;
- if (bdrv_parse_cache_flags(value, &flags) != 0) {
+ if (bdrv_parse_cache_mode(value, &flags, &writethrough) != 0) {
error_report("invalid cache option");
return NULL;
}
@@ -906,7 +907,7 @@ DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_default_type)
/* Specific options take precedence */
if (!qemu_opt_get(all_opts, BDRV_OPT_CACHE_WB)) {
qemu_opt_set_bool(all_opts, BDRV_OPT_CACHE_WB,
- !!(flags & BDRV_O_CACHE_WB), &error_abort);
+ !writethrough, &error_abort);
}
if (!qemu_opt_get(all_opts, BDRV_OPT_CACHE_DIRECT)) {
qemu_opt_set_bool(all_opts, BDRV_OPT_CACHE_DIRECT,
--
1.8.3.1
next prev parent reply other threads:[~2016-03-29 13:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 13:30 [Qemu-devel] [PATCH v2 00/20] block: Implement writethrough in BlockBackend Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 01/20] block: Add bdrv_parse_cache_mode() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 02/20] qemu-nbd: Call blk_set_enable_write_cache() explicitly Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 03/20] qemu-io: " Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 04/20] qemu-img: Expand all BDRV_O_FLAGS uses Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 05/20] qemu-img: Call blk_set_enable_write_cache() explicitly Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 06/20] xen_disk: " Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 07/20] block: blockdev_init(): " Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 08/20] block: Always set writeback mode in blk_new_open() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 09/20] block: Handle flush error in bdrv_pwrite_sync() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 10/20] block: Move enable_write_cache to BB level Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 11/20] block/qapi: Use blk_enable_write_cache() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 12/20] block: Introduce bdrv_co_writev_flags() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 13/20] iscsi: Support BDRV_REQ_FUA Kevin Wolf
2016-03-29 13:43 ` Max Reitz
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 14/20] nbd: " Kevin Wolf
2016-03-29 13:44 ` Max Reitz
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 15/20] raw: " Kevin Wolf
2016-03-29 13:45 ` Max Reitz
2016-03-29 13:30 ` Kevin Wolf [this message]
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f() Kevin Wolf
2016-03-29 13:48 ` Max Reitz
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 18/20] block: Remove bdrv_parse_cache_flags() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 19/20] block: Remove BDRV_O_CACHE_WB Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 20/20] block: Remove bdrv_(set_)enable_write_cache() Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459258257-17767-17-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).