qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v2 06/20] xen_disk: Call blk_set_enable_write_cache() explicitly
Date: Tue, 29 Mar 2016 15:30:43 +0200	[thread overview]
Message-ID: <1459258257-17767-7-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1459258257-17767-1-git-send-email-kwolf@redhat.com>

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
 hw/block/xen_disk.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c
index 635328f..c358709 100644
--- a/hw/block/xen_disk.c
+++ b/hw/block/xen_disk.c
@@ -888,12 +888,14 @@ static int blk_connect(struct XenDevice *xendev)
     struct XenBlkDev *blkdev = container_of(xendev, struct XenBlkDev, xendev);
     int pers, index, qflags;
     bool readonly = true;
+    bool writethrough = true;
 
     /* read-only ? */
     if (blkdev->directiosafe) {
         qflags = BDRV_O_NOCACHE | BDRV_O_NATIVE_AIO;
     } else {
-        qflags = BDRV_O_CACHE_WB;
+        qflags = 0;
+        writethrough = false;
     }
     if (strcmp(blkdev->mode, "w") == 0) {
         qflags |= BDRV_O_RDWR;
@@ -925,6 +927,7 @@ static int blk_connect(struct XenDevice *xendev)
             error_free(local_err);
             return -1;
         }
+        blk_set_enable_write_cache(blkdev->blk, !writethrough);
     } else {
         /* setup via qemu cmdline -> already setup for us */
         xen_be_printf(&blkdev->xendev, 2, "get configured bdrv (cmdline setup)\n");
-- 
1.8.3.1

  parent reply	other threads:[~2016-03-29 13:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29 13:30 [Qemu-devel] [PATCH v2 00/20] block: Implement writethrough in BlockBackend Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 01/20] block: Add bdrv_parse_cache_mode() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 02/20] qemu-nbd: Call blk_set_enable_write_cache() explicitly Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 03/20] qemu-io: " Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 04/20] qemu-img: Expand all BDRV_O_FLAGS uses Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 05/20] qemu-img: Call blk_set_enable_write_cache() explicitly Kevin Wolf
2016-03-29 13:30 ` Kevin Wolf [this message]
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 07/20] block: blockdev_init(): " Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 08/20] block: Always set writeback mode in blk_new_open() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 09/20] block: Handle flush error in bdrv_pwrite_sync() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 10/20] block: Move enable_write_cache to BB level Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 11/20] block/qapi: Use blk_enable_write_cache() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 12/20] block: Introduce bdrv_co_writev_flags() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 13/20] iscsi: Support BDRV_REQ_FUA Kevin Wolf
2016-03-29 13:43   ` Max Reitz
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 14/20] nbd: " Kevin Wolf
2016-03-29 13:44   ` Max Reitz
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 15/20] raw: " Kevin Wolf
2016-03-29 13:45   ` Max Reitz
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 16/20] block: Use bdrv_parse_cache_mode() in drive_init() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f() Kevin Wolf
2016-03-29 13:48   ` Max Reitz
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 18/20] block: Remove bdrv_parse_cache_flags() Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 19/20] block: Remove BDRV_O_CACHE_WB Kevin Wolf
2016-03-29 13:30 ` [Qemu-devel] [PATCH v2 20/20] block: Remove bdrv_(set_)enable_write_cache() Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459258257-17767-7-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).