From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akvGz-0002xF-6a for qemu-devel@nongnu.org; Tue, 29 Mar 2016 11:09:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akvGt-00066h-6p for qemu-devel@nongnu.org; Tue, 29 Mar 2016 11:09:37 -0400 From: Kevin Wolf Date: Tue, 29 Mar 2016 17:08:10 +0200 Message-Id: <1459264128-12761-11-git-send-email-kwolf@redhat.com> In-Reply-To: <1459264128-12761-1-git-send-email-kwolf@redhat.com> References: <1459264128-12761-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 10/48] block/qapi: fix unbounded stack for dump_qdict List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Peter Xu Using heap instead of stack for better safety. Signed-off-by: Peter Xu Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block/qapi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/qapi.c b/block/qapi.c index 7be3f4a..775dcf5 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -668,7 +668,7 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, for (entry = qdict_first(dict); entry; entry = qdict_next(dict, entry)) { QType type = qobject_type(entry->value); bool composite = (type == QTYPE_QDICT || type == QTYPE_QLIST); - char key[strlen(entry->key) + 1]; + char *key = g_malloc(strlen(entry->key) + 1); int i; /* replace dashes with spaces in key (variable) names */ @@ -682,6 +682,7 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, if (!composite) { func_fprintf(f, "\n"); } + g_free(key); } } -- 1.8.3.1