From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [RFC v2 0/9] virtio: avoid exit() when device enters invalid states
Date: Tue, 29 Mar 2016 17:12:52 +0100 [thread overview]
Message-ID: <1459267981-23408-1-git-send-email-stefanha@redhat.com> (raw)
v2:
* Add VIRTIO_CONFIG_S_NEEDS_RESET notification for VIRTIO 1.0 [Cornelia]
(Note I've sent a Linux virtio_config.h patch to get the constant added to
the headers.)
* Split int -> unsigned int change into separate commit [Fam]
* Fix double "index" typo in commit description [Fam]
The virtio code calls exit() when the device enters an invalid state. This
means invalid vring indices and descriptor chains kill the VM. See the patch
descriptions for why this is a bad thing.
When the virtio device is in the broken state calls to virtqueue_pop() and
friends will pretend the virtqueue is empty. This means the device will become
isolated from guest activity until it is reset again.
RFC because two things are missing:
1. Live migration support (subsection for broken flag?)
2. Auditing devices and replacing exit() calls there too
Stefan Hajnoczi (9):
virtio: fix stray tab character
include: update virtio_config.h Linux header
virtio: stop virtqueue processing if device is broken
virtio: handle virtqueue_map_desc() errors
virtio: handle virtqueue_get_avail_bytes() errors
virtio: use unsigned int for virtqueue_get_avail_bytes() index
virtio: handle virtqueue_read_next_desc() errors
virtio: handle virtqueue_num_heads() errors
virtio: handle virtqueue_get_head() errors
hw/virtio/virtio.c | 204 +++++++++++++++++++------
include/hw/virtio/virtio.h | 3 +
include/standard-headers/linux/virtio_config.h | 2 +
3 files changed, 162 insertions(+), 47 deletions(-)
--
2.5.5
next reply other threads:[~2016-03-29 16:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 16:12 Stefan Hajnoczi [this message]
2016-03-29 16:12 ` [Qemu-devel] [RFC v2 1/9] virtio: fix stray tab character Stefan Hajnoczi
2016-04-07 14:50 ` Markus Armbruster
2016-04-08 9:06 ` Stefan Hajnoczi
2016-04-08 11:10 ` Markus Armbruster
2016-03-29 16:12 ` [Qemu-devel] [RFC v2 2/9] include: update virtio_config.h Linux header Stefan Hajnoczi
2016-03-29 16:12 ` [Qemu-devel] [RFC v2 3/9] virtio: stop virtqueue processing if device is broken Stefan Hajnoczi
2016-03-29 16:58 ` Cornelia Huck
2016-03-30 12:19 ` Stefan Hajnoczi
2016-03-30 12:21 ` Stefan Hajnoczi
2016-03-29 16:12 ` [Qemu-devel] [RFC v2 4/9] virtio: handle virtqueue_map_desc() errors Stefan Hajnoczi
2016-03-29 16:12 ` [Qemu-devel] [RFC v2 5/9] virtio: handle virtqueue_get_avail_bytes() errors Stefan Hajnoczi
2016-03-29 16:12 ` [Qemu-devel] [RFC v2 6/9] virtio: use unsigned int for virtqueue_get_avail_bytes() index Stefan Hajnoczi
2016-03-29 16:12 ` [Qemu-devel] [RFC v2 7/9] virtio: handle virtqueue_read_next_desc() errors Stefan Hajnoczi
2016-03-29 16:13 ` [Qemu-devel] [RFC v2 8/9] virtio: handle virtqueue_num_heads() errors Stefan Hajnoczi
2016-03-29 16:13 ` [Qemu-devel] [RFC v2 9/9] virtio: handle virtqueue_get_head() errors Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459267981-23408-1-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=famz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).