qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: crobinso@redhat.com, stefanb@us.ibm.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH] pc: acpi: tpm: add missing MMIO resource to PCI0._CRS
Date: Wed, 30 Mar 2016 15:35:06 +0200	[thread overview]
Message-ID: <1459344906-46409-1-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1458570071-1935-1-git-send-email-stefanb@us.ibm.com>

Windows will fail it initialize TMP driver with the reason:
  'device cannot find enough free resources'
That happens because parent BUS doesn't describe
MMIO resources used by TPM child device.
Fix it by describing it in top-most parent bus scope PCI0.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 hw/i386/acpi-build.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 35180ef..784870e 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -2167,6 +2167,11 @@ build_dsdt(GArray *table_data, GArray *linker,
                              0, pci->w64.begin, pci->w64.end - 1, 0,
                              pci->w64.end - pci->w64.begin));
     }
+
+    if (misc->tpm_version != TPM_VERSION_UNSPEC) {
+        aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE,
+                   TPM_TIS_ADDR_SIZE, AML_READ_WRITE));
+    }
     aml_append(scope, aml_name_decl("_CRS", crs));
 
     /* reserve GPE0 block resources */
-- 
1.8.3.1

      parent reply	other threads:[~2016-03-30 13:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 14:21 [Qemu-devel] [PATCH] acpi: Fix TPM ACPI description to make TPM usable on Windows Stefan Berger
2016-03-21 15:32 ` Cole Robinson
2016-03-30 13:33 ` Igor Mammedov
2016-03-31  4:03   ` Stefan Berger
2016-03-31  9:50     ` Igor Mammedov
2016-03-31 14:07     ` Igor Mammedov
2016-04-01 18:50       ` Stefan Berger
2016-04-02 19:35         ` Igor Mammedov
2016-04-03 13:33         ` Michael S. Tsirkin
2016-04-04 11:05       ` Marcel Apfelbaum
2016-03-30 13:35 ` Igor Mammedov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459344906-46409-1-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=crobinso@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).