* [Qemu-devel] [PATCH v1] util: don't use AI_V4MAPPED flag to getaddrinfo on FreeBSD
@ 2016-03-31 13:06 Daniel P. Berrange
0 siblings, 0 replies; only message in thread
From: Daniel P. Berrange @ 2016-03-31 13:06 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Gerd Hoffmann
The FreeBSD header files define the AI_V4MAPPED but its
implementation of getaddrinfo() always returns an error
when that flag is set. eg
address resolution failed for localhost:9000: Invalid value for ai_flags
Since this flag is not critical for DNS lookups, just
undefine it on FreeBSD platforms.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
util/qemu-sockets.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index b87e17f..3007345 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -29,6 +29,15 @@
#ifndef AI_ADDRCONFIG
# define AI_ADDRCONFIG 0
#endif
+
+/* FreeBSD defines AI_V4MAPPED in its header files but its
+ * getaddrinfo() implementation always returns an error
+ * when it is used. Tested with FreeBSD 10.2. Recheck new
+ * releases periodically to see if this gets fixed....
+ */
+#if defined(AI_V4MAPPED) && defined(__FreeBSD__)
+# undef AI_V4MAPPED
+#endif
#ifndef AI_V4MAPPED
# define AI_V4MAPPED 0
#endif
--
2.5.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-03-31 13:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-31 13:06 [Qemu-devel] [PATCH v1] util: don't use AI_V4MAPPED flag to getaddrinfo on FreeBSD Daniel P. Berrange
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).