* [Qemu-devel] [PATCH v1] net: fix missing include of qapi/error.h in netmap.c
@ 2016-03-31 13:08 Daniel P. Berrange
2016-03-31 16:19 ` Eric Blake
2016-04-04 14:54 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Daniel P. Berrange @ 2016-03-31 13:08 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
The netmap.c file fails to build on FreeBSD with
net/netmap.c:95:9: warning: implicit declaration of function 'error_setg_errno' is invalid in C99 [-Wimplicit-function-declaration]
error_setg_errno(errp, errno, "Failed to nm_open() %s",
^
net/netmap.c:432:9: warning: implicit declaration of function 'error_propagate' is invalid in C99 [-Wimplicit-function-declaration]
error_propagate(errp, err);
^
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
net/netmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/netmap.c b/net/netmap.c
index d9c21b2..6cc0db5 100644
--- a/net/netmap.c
+++ b/net/netmap.c
@@ -36,6 +36,7 @@
#include "clients.h"
#include "sysemu/sysemu.h"
#include "qemu/error-report.h"
+#include "qapi/error.h"
#include "qemu/iov.h"
#include "qemu/cutils.h"
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v1] net: fix missing include of qapi/error.h in netmap.c
2016-03-31 13:08 [Qemu-devel] [PATCH v1] net: fix missing include of qapi/error.h in netmap.c Daniel P. Berrange
@ 2016-03-31 16:19 ` Eric Blake
2016-04-04 14:54 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2016-03-31 16:19 UTC (permalink / raw)
To: Daniel P. Berrange, qemu-devel; +Cc: qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
On 03/31/2016 07:08 AM, Daniel P. Berrange wrote:
> The netmap.c file fails to build on FreeBSD with
>
> net/netmap.c:95:9: warning: implicit declaration of function 'error_setg_errno' is invalid in C99 [-Wimplicit-function-declaration]
> error_setg_errno(errp, errno, "Failed to nm_open() %s",
> ^
> net/netmap.c:432:9: warning: implicit declaration of function 'error_propagate' is invalid in C99 [-Wimplicit-function-declaration]
> error_propagate(errp, err);
> ^
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> net/netmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v1] net: fix missing include of qapi/error.h in netmap.c
2016-03-31 13:08 [Qemu-devel] [PATCH v1] net: fix missing include of qapi/error.h in netmap.c Daniel P. Berrange
2016-03-31 16:19 ` Eric Blake
@ 2016-04-04 14:54 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2016-04-04 14:54 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: QEMU Trivial, QEMU Developers
On 31 March 2016 at 14:08, Daniel P. Berrange <berrange@redhat.com> wrote:
> The netmap.c file fails to build on FreeBSD with
>
> net/netmap.c:95:9: warning: implicit declaration of function 'error_setg_errno' is invalid in C99 [-Wimplicit-function-declaration]
> error_setg_errno(errp, errno, "Failed to nm_open() %s",
> ^
> net/netmap.c:432:9: warning: implicit declaration of function 'error_propagate' is invalid in C99 [-Wimplicit-function-declaration]
> error_propagate(errp, err);
> ^
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> net/netmap.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-04 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-31 13:08 [Qemu-devel] [PATCH v1] net: fix missing include of qapi/error.h in netmap.c Daniel P. Berrange
2016-03-31 16:19 ` Eric Blake
2016-04-04 14:54 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).