From: Alex Bligh <alex@alex.org.uk>
To: Eric Blake <eblake@redhat.com>, Wouter Verhelst <w@uter.be>
Cc: "nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Alex Bligh <alex@alex.org.uk>
Subject: [Qemu-devel] [PATCH 1/2] proto.md: Clearly set out NBDMAGIC is the actual value
Date: Thu, 31 Mar 2016 19:15:24 +0100 [thread overview]
Message-ID: <1459448124-52318-1-git-send-email-alex@alex.org.uk> (raw)
Clearly set out NBDMAGIC, not the name of a constant equal to
some value. Set out the value in hex as well.
Signed-off-by: Alex Bligh <alex@alex.org.uk>
---
doc/proto.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/proto.md b/doc/proto.md
index c1e05c5..7994076 100644
--- a/doc/proto.md
+++ b/doc/proto.md
@@ -67,7 +67,7 @@ newstyle negotiation.
#### Oldstyle negotiation
-S: 64 bits, `NBDMAGIC` (also known as the `INIT_PASSWD`)
+S: 64 bits, `0x4e42444d41474943` (ASCII '`NBDMAGIC`') (also known as the `INIT_PASSWD`)
S: 64 bits, `0x00420281861253` (`cliserv_magic`, a magic number)
S: 64 bits, size of the export in bytes (unsigned)
S: 32 bits, flags
@@ -96,7 +96,7 @@ production purposes.
The initial few exchanges in newstyle negotiation look as follows:
-S: 64 bits, `NBDMAGIC` (as in the old style handshake)
+S: 64 bits, `0x4e42444d41474943` (ASCII '`NBDMAGIC`') (as in the old style handshake)
S: 64 bits, `0x49484156454F5054` (note different magic number)
S: 16 bits, handshake flags
C: 32 bits, flags
--
1.9.1
next reply other threads:[~2016-03-31 18:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 18:15 Alex Bligh [this message]
2016-03-31 19:08 ` [Qemu-devel] [PATCH 1/2] proto.md: Clearly set out NBDMAGIC is the actual value Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459448124-52318-1-git-send-email-alex@alex.org.uk \
--to=alex@alex.org.uk \
--cc=eblake@redhat.com \
--cc=nbd-general@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
--cc=w@uter.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).