From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alh7v-0006LJ-2U for qemu-devel@nongnu.org; Thu, 31 Mar 2016 14:15:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alh7u-0004Gc-4A for qemu-devel@nongnu.org; Thu, 31 Mar 2016 14:15:26 -0400 Received: from mail.avalus.com ([2001:41c8:10:1dd::10]:41591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alh7t-0004GV-UO for qemu-devel@nongnu.org; Thu, 31 Mar 2016 14:15:26 -0400 From: Alex Bligh Date: Thu, 31 Mar 2016 19:15:24 +0100 Message-Id: <1459448124-52318-1-git-send-email-alex@alex.org.uk> Subject: [Qemu-devel] [PATCH 1/2] proto.md: Clearly set out NBDMAGIC is the actual value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Wouter Verhelst Cc: "nbd-general@lists.sourceforge.net" , "qemu-devel@nongnu.org" , Alex Bligh Clearly set out NBDMAGIC, not the name of a constant equal to some value. Set out the value in hex as well. Signed-off-by: Alex Bligh --- doc/proto.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/proto.md b/doc/proto.md index c1e05c5..7994076 100644 --- a/doc/proto.md +++ b/doc/proto.md @@ -67,7 +67,7 @@ newstyle negotiation. #### Oldstyle negotiation -S: 64 bits, `NBDMAGIC` (also known as the `INIT_PASSWD`) +S: 64 bits, `0x4e42444d41474943` (ASCII '`NBDMAGIC`') (also known as the `INIT_PASSWD`) S: 64 bits, `0x00420281861253` (`cliserv_magic`, a magic number) S: 64 bits, size of the export in bytes (unsigned) S: 32 bits, flags @@ -96,7 +96,7 @@ production purposes. The initial few exchanges in newstyle negotiation look as follows: -S: 64 bits, `NBDMAGIC` (as in the old style handshake) +S: 64 bits, `0x4e42444d41474943` (ASCII '`NBDMAGIC`') (as in the old style handshake) S: 64 bits, `0x49484156454F5054` (note different magic number) S: 16 bits, handshake flags C: 32 bits, flags -- 1.9.1