From: Alex Bligh <alex@alex.org.uk>
To: Eric Blake <eblake@redhat.com>, Wouter Verhelst <w@uter.be>
Cc: "nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Alex Bligh <alex@alex.org.uk>
Subject: [Qemu-devel] [PATCH 2/2] Correct definition of NBD_CMD_FLAG_FUA
Date: Thu, 31 Mar 2016 19:15:32 +0100 [thread overview]
Message-ID: <1459448132-52364-1-git-send-email-alex@alex.org.uk> (raw)
NBD_CMD_FLAG_FUA is defined as 1<<0 in the documentation, but
1<<16 in nbd.h. It is not used anywhere within the code.
1<<16 cannot work as the flags word is only 16 bits long.
It is doubtful whether anyone is using NBD_CMD_FLAG_FUA
at the moment in any case.
Signed-off-by: Alex Bligh <alex@alex.org.uk>
---
nbd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nbd.h b/nbd.h
index f2a32dd..53b6ca1 100644
--- a/nbd.h
+++ b/nbd.h
@@ -38,7 +38,7 @@ enum {
};
#define NBD_CMD_MASK_COMMAND 0x0000ffff
-#define NBD_CMD_FLAG_FUA (1<<16)
+#define NBD_CMD_FLAG_FUA (1 << 0)
/* values for flags field */
#define NBD_FLAG_HAS_FLAGS (1 << 0) /* Flags are there */
--
1.9.1
next reply other threads:[~2016-03-31 18:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 18:15 Alex Bligh [this message]
2016-03-31 18:21 ` [Qemu-devel] [PATCH 2/2] Correct definition of NBD_CMD_FLAG_FUA Alex Bligh
2016-03-31 19:14 ` Eric Blake
2016-03-31 19:25 ` Alex Bligh
2016-03-31 20:07 ` Eric Blake
2016-03-31 20:19 ` Alex Bligh
2016-04-01 7:59 ` [Qemu-devel] [Nbd] " Wouter Verhelst
2016-04-01 9:32 ` Alex Bligh
2016-04-01 9:43 ` Wouter Verhelst
2016-04-01 10:11 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459448132-52364-1-git-send-email-alex@alex.org.uk \
--to=alex@alex.org.uk \
--cc=eblake@redhat.com \
--cc=nbd-general@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
--cc=w@uter.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).