From: "Cédric Le Goater" <clg@fr.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Cédric Le Goater" <clg@fr.ibm.com>,
qemu-devel@nongnu.org, "Greg Kurz" <gkurz@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH] checkpatch: add target_ulong to typelist
Date: Fri, 1 Apr 2016 11:40:06 +0200 [thread overview]
Message-ID: <1459503606-31603-1-git-send-email-clg@fr.ibm.com> (raw)
In some occasions, a patch [1] can start with a hunk containing a
simple type cast. At the time annotate_values() is run, the type is
unknown and the cast type is misinterpreted as a identifier, resulting
in an error if it is followed with a negative value:
ERROR: spaces required around that '-' (ctx:WxV)
It seems complex to catch all possible types in a cast expression. So,
as a fallback solution, let's add some common qemu types to the
typeList array.
[1] http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg06741.html
Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
Index: qemu-dgibson-for-2.6.git/scripts/checkpatch.pl
===================================================================
--- qemu-dgibson-for-2.6.git.orig/scripts/checkpatch.pl
+++ qemu-dgibson-for-2.6.git/scripts/checkpatch.pl
@@ -212,6 +212,7 @@ our @typeList = (
qr{${Ident}_t},
qr{${Ident}_handler},
qr{${Ident}_handler_fn},
+ qr{target_(?:u)?long},
);
# This can be modified by sub possible. Since it can be empty, be careful
next reply other threads:[~2016-04-01 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 9:40 Cédric Le Goater [this message]
2016-04-01 9:50 ` [Qemu-devel] [PATCH] checkpatch: add target_ulong to typelist Greg Kurz
2016-04-01 10:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459503606-31603-1-git-send-email-clg@fr.ibm.com \
--to=clg@fr.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).