From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anNBU-00089k-JC for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:22:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anNBP-00031Y-PR for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:22:04 -0400 Received: from e06smtp07.uk.ibm.com ([195.75.94.103]:36164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anNBP-0002zv-Bm for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:21:59 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Apr 2016 10:21:58 +0100 From: Sascha Silbe Date: Tue, 5 Apr 2016 11:21:49 +0200 Message-Id: <1459848109-29756-8-git-send-email-silbe@linux.vnet.ibm.com> In-Reply-To: <1459848109-29756-1-git-send-email-silbe@linux.vnet.ibm.com> References: <1459848109-29756-1-git-send-email-silbe@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 7/7] qemu-iotests: iotests.py: get rid of __all__ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf Cc: Tu Bo The __all__ list contained a typo for as long as the iotests module existed. That typo prevented "from iotests import *" (which is the only case where iotests.__all__ is used at all) from ever working. The names used by iotests are highly prone to name collisions, so importing them all unconditionally is a bad idea anyway. Since __all__ is not adding any value, let's just get rid of it. Fixes: f345cfd0 ("qemu-iotests: add iotests Python module") Signed-off-by: Sascha Silbe Reviewed-by: Bo Tu --- tests/qemu-iotests/iotests.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index bf31ec8..0c0b533 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -29,10 +29,6 @@ import qmp import qtest import struct -__all__ = ['imgfmt', 'imgproto', 'test_dir' 'qemu_img', 'qemu_io', - 'VM', 'QMPTestCase', 'notrun', 'main', 'verify_image_format', - 'verify_platform', 'filter_test_dir', 'filter_win32', - 'filter_qemu_io', 'filter_chown', 'log'] # This will not work if arguments contain spaces but is necessary if we # want to support the override options that ./check supports. -- 1.9.1