From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, jasowang@redhat.com, armbru@redhat.com,
marcel@redhat.com, alex.williamson@redhat.com, hare@suse.de,
dmitry@daynix.com, pbonzini@redhat.com, jsnow@redhat.com,
kraxel@redhat.com
Subject: [Qemu-devel] [PATCH v4 3/5] megasas: bugfix
Date: Tue, 5 Apr 2016 19:26:40 +0800 [thread overview]
Message-ID: <1459855602-16727-4-git-send-email-caoj.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <1459855602-16727-1-git-send-email-caoj.fnst@cn.fujitsu.com>
msi_init returns non-zero value on both failure and success
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
CC: Hannes Reinecke <hare@suse.de>
CC: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/megasas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index a63a581..56fb645 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -2348,7 +2348,7 @@ static void megasas_scsi_realize(PCIDevice *dev, Error **errp)
"megasas-queue", 0x40000);
if (megasas_use_msi(s) &&
- msi_init(dev, 0x50, 1, true, false)) {
+ msi_init(dev, 0x50, 1, true, false) < 0) {
s->flags &= ~MEGASAS_MASK_USE_MSI;
}
if (megasas_use_msix(s) &&
--
2.1.0
next prev parent reply other threads:[~2016-04-05 11:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 11:26 [Qemu-devel] [PATCH v4 0/5] Add param Error ** for msi_init() Cao jin
2016-04-05 11:26 ` [Qemu-devel] [PATCH v4 1/5] fix some coding style problems Cao jin
2016-04-08 6:29 ` Markus Armbruster
2016-04-09 8:49 ` Cao jin
2016-04-05 11:26 ` [Qemu-devel] [PATCH v4 2/5] change pvscsi_init_msi() type to void Cao jin
2016-04-06 7:19 ` Dmitry Fleytman
2016-04-10 7:41 ` Marcel Apfelbaum
2016-04-05 11:26 ` Cao jin [this message]
2016-04-08 7:16 ` [Qemu-devel] [PATCH v4 3/5] megasas: bugfix Markus Armbruster
2016-04-09 13:07 ` Cao jin
2016-04-10 7:40 ` Marcel Apfelbaum
2016-04-05 11:26 ` [Qemu-devel] [PATCH v4 4/5] mptsas: change .realize function name Cao jin
2016-04-10 7:43 ` Marcel Apfelbaum
2016-04-05 11:26 ` [Qemu-devel] [PATCH v4 5/5] Add param Error ** for msi_init() Cao jin
2016-04-08 8:44 ` Markus Armbruster
2016-04-09 12:19 ` Cao jin
2016-04-09 13:00 ` Cao jin
2016-04-10 8:20 ` Marcel Apfelbaum
2016-04-10 9:38 ` Cao jin
2016-04-11 10:00 ` Marcel Apfelbaum
2016-04-11 12:02 ` Cao jin
2016-04-12 11:50 ` Markus Armbruster
2016-04-29 9:28 ` Cao jin
2016-04-29 12:46 ` Markus Armbruster
2016-04-12 8:34 ` Markus Armbruster
2016-04-05 11:27 ` [Qemu-devel] [PATCH v4 0/5] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459855602-16727-4-git-send-email-caoj.fnst@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=dmitry@daynix.com \
--cc=hare@suse.de \
--cc=jasowang@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).