[Qemu-devel] [PATCH v1] Changed malloc to g_malloc, free to g_free in ui/shader.c

[Qemu-devel] [PATCH v1] Changed malloc to g_malloc, free to g_free in ui/shader.c

[Md Haris Iqbal]

Signed-off-by: Md Haris Iqbal <haris.phnx@gmail.com>
---
 ui/shader.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/ui/shader.c b/ui/shader.c
index 9264009..1ffddbe 100644
--- a/ui/shader.c
+++ b/ui/shader.c
@@ -83,12 +83,12 @@ GLuint qemu_gl_create_compile_shader(GLenum type, const GLchar *src)
     glGetShaderiv(shader, GL_COMPILE_STATUS, &status);
     if (!status) {
         glGetShaderiv(shader, GL_INFO_LOG_LENGTH, &length);
-        errmsg = malloc(length);
+        errmsg = g_malloc(length);
         glGetShaderInfoLog(shader, length, &length, errmsg);
         fprintf(stderr, "%s: compile %s error\n%s\n", __func__,
                 (type == GL_VERTEX_SHADER) ? "vertex" : "fragment",
                 errmsg);
-        free(errmsg);
+        g_free(errmsg);
         return 0;
     }
     return shader;
@@ -108,10 +108,10 @@ GLuint qemu_gl_create_link_program(GLuint vert, GLuint frag)
     glGetProgramiv(program, GL_LINK_STATUS, &status);
     if (!status) {
         glGetProgramiv(program, GL_INFO_LOG_LENGTH, &length);
-        errmsg = malloc(length);
+        errmsg = g_malloc(length);
         glGetProgramInfoLog(program, length, &length, errmsg);
         fprintf(stderr, "%s: link program: %s\n", __func__, errmsg);
-        free(errmsg);
+        g_free(errmsg);
         return 0;
     }
     return program;
-- 
1.9.1

Re: [Qemu-devel] [PATCH v1] Changed malloc to g_malloc, free to g_free in ui/shader.c

[haris iqbal]

Just a reminder. waiting for a review for the previous patch.

On Tue, Apr 5, 2016 at 6:51 PM, Md Haris Iqbal <haris.phnx@gmail.com> wrote:
> Signed-off-by: Md Haris Iqbal <haris.phnx@gmail.com>
> ---
>  ui/shader.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/ui/shader.c b/ui/shader.c
> index 9264009..1ffddbe 100644
> --- a/ui/shader.c
> +++ b/ui/shader.c
> @@ -83,12 +83,12 @@ GLuint qemu_gl_create_compile_shader(GLenum type, const GLchar *src)
>      glGetShaderiv(shader, GL_COMPILE_STATUS, &status);
>      if (!status) {
>          glGetShaderiv(shader, GL_INFO_LOG_LENGTH, &length);
> -        errmsg = malloc(length);
> +        errmsg = g_malloc(length);
>          glGetShaderInfoLog(shader, length, &length, errmsg);
>          fprintf(stderr, "%s: compile %s error\n%s\n", __func__,
>                  (type == GL_VERTEX_SHADER) ? "vertex" : "fragment",
>                  errmsg);
> -        free(errmsg);
> +        g_free(errmsg);
>          return 0;
>      }
>      return shader;
> @@ -108,10 +108,10 @@ GLuint qemu_gl_create_link_program(GLuint vert, GLuint frag)
>      glGetProgramiv(program, GL_LINK_STATUS, &status);
>      if (!status) {
>          glGetProgramiv(program, GL_INFO_LOG_LENGTH, &length);
> -        errmsg = malloc(length);
> +        errmsg = g_malloc(length);
>          glGetProgramInfoLog(program, length, &length, errmsg);
>          fprintf(stderr, "%s: link program: %s\n", __func__, errmsg);
> -        free(errmsg);
> +        g_free(errmsg);
>          return 0;
>      }
>      return program;
> --
> 1.9.1
>



-- 

With regards,

Md Haris Iqbal,
Placement Coordinator, MTech IT
NITK Surathkal,
Contact: +91 8861996962

Re: [Qemu-devel] [PATCH v1] Changed malloc to g_malloc, free to g_free in ui/shader.c

[Gerd Hoffmann]

On Di, 2016-05-03 at 15:16 +0530, haris iqbal wrote:
> Just a reminder. waiting for a review for the previous patch.

Patch is fine.  Just stalled b/c we are in code freeze, I expect trivial
queue will pick this up for the 2.7 devel cycle.

cheers,
  Gerd

Re: [Qemu-devel] [PATCH v1] Changed malloc to g_malloc, free to g_free in ui/shader.c

[haris iqbal]

On Tue, May 3, 2016 at 3:42 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> On Di, 2016-05-03 at 15:16 +0530, haris iqbal wrote:
>> Just a reminder. waiting for a review for the previous patch.
>
> Patch is fine.  Just stalled b/c we are in code freeze, I expect trivial
> queue will pick this up for the 2.7 devel cycle.
>
> cheers,
>   Gerd
>

Thanks for the fast response. :)


-- 

With regards,

Md Haris Iqbal,
Placement Coordinator, MTech IT
NITK Surathkal,
Contact: +91 8861996962<div id="DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2"><br />
<table style="border-top: 1px solid #aaabb6;">
	<tr>
        <td style="width: 55px; padding-top: 13px;"><a
href="https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail"
target="_blank"><img
src="https://ipmcdn.avast.com/images/2016/icons/icon-envelope-tick-round-orange-v1.png"
/></a></td>
		<td style="width: 470px; padding-top: 15px; color: #41424e;
font-size: 13px; font-family: Arial, Helvetica, sans-serif;
line-height: 18px;">Virus-free. <a
href="https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail"
target="_blank" style="color: #4453ea;">www.avast.com</a>
		</td>
	</tr>
</table><a href="#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2" width="1"
height="1"></a></div>

Re: [Qemu-devel] [PATCH v1] Changed malloc to g_malloc, free to g_free in ui/shader.c

[Gerd Hoffmann]

On Di, 2016-04-05 at 18:51 +0530, Md Haris Iqbal wrote:
> Signed-off-by: Md Haris Iqbal <haris.phnx@gmail.com>

Picked up for next ui pull request.

thanks,
  Gerd