From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1andM9-0000rm-B8 for qemu-devel@nongnu.org; Tue, 05 Apr 2016 22:38:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1andM8-0002fW-F2 for qemu-devel@nongnu.org; Tue, 05 Apr 2016 22:38:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1andM8-0002fA-9n for qemu-devel@nongnu.org; Tue, 05 Apr 2016 22:38:08 -0400 From: Jason Wang Date: Wed, 6 Apr 2016 10:37:57 +0800 Message-Id: <1459910280-5101-3-git-send-email-jasowang@redhat.com> In-Reply-To: <1459910280-5101-1-git-send-email-jasowang@redhat.com> References: <1459910280-5101-1-git-send-email-jasowang@redhat.com> Subject: [Qemu-devel] [PULL 2/5] net: Allocating Large sized arrays to heap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: Jason Wang , Pooja Dhannawat From: Pooja Dhannawat nc_sendv_compat has a huge stack usage of 69680 bytes approx. Moving large arrays to heap to reduce stack usage. Reviewed-by: Stefan Hajnoczi Signed-off-by: Pooja Dhannawat Signed-off-by: Jason Wang --- net/net.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/net/net.c b/net/net.c index 0bc42a1..f8b1e00 100644 --- a/net/net.c +++ b/net/net.c @@ -683,23 +683,28 @@ ssize_t qemu_send_packet_raw(NetClientState *nc, const uint8_t *buf, int size) static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, int iovcnt, unsigned flags) { - uint8_t buf[NET_BUFSIZE]; + uint8_t *buf = NULL; uint8_t *buffer; size_t offset; + ssize_t ret; if (iovcnt == 1) { buffer = iov[0].iov_base; offset = iov[0].iov_len; } else { + buf = g_new(uint8_t, NET_BUFSIZE); buffer = buf; - offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); + offset = iov_to_buf(iov, iovcnt, 0, buf, NET_BUFSIZE); } if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { - return nc->info->receive_raw(nc, buffer, offset); + ret = nc->info->receive_raw(nc, buffer, offset); } else { - return nc->info->receive(nc, buffer, offset); + ret = nc->info->receive(nc, buffer, offset); } + + g_free(buf); + return ret; } ssize_t qemu_deliver_packet_iov(NetClientState *sender, -- 2.5.0