From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aneFU-0003cb-7o for qemu-devel@nongnu.org; Tue, 05 Apr 2016 23:35:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aneFP-0002N9-5T for qemu-devel@nongnu.org; Tue, 05 Apr 2016 23:35:20 -0400 Received: from resqmta-po-09v.sys.comcast.net ([2001:558:fe16:19:96:114:154:168]:33337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aneFO-0002ME-Uj for qemu-devel@nongnu.org; Tue, 05 Apr 2016 23:35:15 -0400 From: Eric Blake Date: Tue, 5 Apr 2016 21:35:02 -0600 Message-Id: <1459913704-19949-2-git-send-email-eblake@redhat.com> In-Reply-To: <1459913704-19949-1-git-send-email-eblake@redhat.com> References: <1459913704-19949-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] nbd: Return correct error for write to read-only export List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com The NBD Protocol requires that servers should send EPERM for attempts to write (or trim) a read-only export. We were correct for TRIM (blk_co_discard() gave EPERM); but were manually setting EROFS which then got mapped to EINVAL over the wire on writes. Signed-off-by: Eric Blake --- nbd/server.c | 1 + 1 file changed, 1 insertion(+) diff --git a/nbd/server.c b/nbd/server.c index b95571b..98e3957 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -26,6 +26,7 @@ static int system_errno_to_nbd_errno(int err) case 0: return NBD_SUCCESS; case EPERM: + case EROFS: return NBD_EPERM; case EIO: return NBD_EIO; -- 2.5.5